Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve curve approximation caching code #1091

Merged
merged 11 commits into from
Sep 15, 2022
Merged

Improve curve approximation caching code #1091

merged 11 commits into from
Sep 15, 2022

Commits on Sep 15, 2022

  1. Refactor 

    The only purpose of this change is to make a following change smaller.
    @hannobraun
    hannobraun committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    e7de5d5 View commit details
    Browse the repository at this point in the history

  2. Make function generic over dimension

    @hannobraun
    hannobraun committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    eed2889 View commit details
    Browse the repository at this point in the history

  3. Simplify struct

    @hannobraun
    hannobraun committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    7209f30 View commit details
    Browse the repository at this point in the history

  4. Return more flexible type from path approximation

    @hannobraun
    hannobraun committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    c4aa84e View commit details
    Browse the repository at this point in the history

  5. Repurpose GlobalPathApprox 

    This reverts a change I made earlier. Things are going into a different
direction than I initially expected.
    @hannobraun
    hannobraun committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    2911017 View commit details
    Browse the repository at this point in the history

  6. Rename method arguments 

    The new names reflect their use much better.
    @hannobraun
    hannobraun committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    c0c28ba View commit details
    Browse the repository at this point in the history

  7. Update struct field name 

    It doesn't contain `GlobalCurve`s, it is the cache that handles global
curve approximations. I think the new name might capture that a tiny bit
better, without becoming too verbose.
    @hannobraun
    hannobraun committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    b3ddbb7 View commit details
    Browse the repository at this point in the history

  8. Include range in key for global curve approx cache 

    Leaving out the range only worked accidentally, given the current
feature set and set of models in the repository.
    @hannobraun
    hannobraun committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    e33171a View commit details
    Browse the repository at this point in the history

  9. Make variable name more specific

    @hannobraun
    hannobraun committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    3d81a38 View commit details
    Browse the repository at this point in the history

  10. Refactor

    @hannobraun
    hannobraun committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    5c33a73 View commit details
    Browse the repository at this point in the history

  11. Handle curve approx caching in Curve approx 

    The goal is to bypass and remove `GlobalCurve` approximation, so the
caching needs to be moved out of there.
    @hannobraun
    hannobraun committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    810c175 View commit details
    Browse the repository at this point in the history