Improve curve approximation caching code #1091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts a change I made earlier. Things are going into a different direction than I initially expected.
The new names reflect their use much better.
It doesn't contain `GlobalCurve`s, it is the cache that handles global curve approximations. I think the new name might capture that a tiny bit better, without becoming too verbose.
Leaving out the range only worked accidentally, given the current feature set and set of models in the repository.
The goal is to bypass and remove `GlobalCurve` approximation, so the caching needs to be moved out of there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is some more progress as I'm working on addressing #1079.