Skip to content
This repository has been archived by the owner on Sep 11, 2019. It is now read-only.

docs: quickstart bug fix #81

Closed
wants to merge 1 commit into from
Closed

docs: quickstart bug fix #81

wants to merge 1 commit into from

Conversation

ryanomackey
Copy link
Member

Looks like you need to pass it an empty array or it throws an error.

@ryanomackey
docs: quickstart bug fix
3f52140 
Looks like you need to pass it an empty array or it throws an error.
@jlengstorf jlengstorf mentioned this pull request Feb 26, 2018
Open
@jlengstorf
Copy link
Member

Hmm... that shouldn't be the case. I wonder if that was introduced by extracting the prepare steps.

https://github.com/gramps-graphql/gramps/blob/master/src/gramps.js#L166-L167

I know it's an extreme edge case, but my preference would be for no error to occur with a gramps() call. I've opened #84 to track this.

jlengstorf added a commit that referenced this pull request Mar 6, 2018
@jlengstorf
fix: allow gramps() calls with no options
e01fc59 
- Remove rest/spread for `gramps()` args
- Add single options object with a default

close #81, close #84
@jlengstorf jlengstorf mentioned this pull request Mar 6, 2018
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jlengstorf jlengstorf Awaiting requested review from jlengstorf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ryanomackey @jlengstorf