Skip to content
This repository has been archived by the owner on Sep 11, 2019. It is now read-only.

Calling gramps() with no arguments causes an error #84

Open
jlengstorf opened this issue Feb 26, 2018 · 2 comments · May be fixed by #86
Open

Calling gramps() with no arguments causes an error #84

jlengstorf opened this issue Feb 26, 2018 · 2 comments · May be fixed by #86

Comments

@jlengstorf
Copy link
Member

Per #81, it looks like we added a regression when we extracted prepare() into its own function. The gramps() call no longer works without arguments.

This is minor, but something I'd like to fix.
@jlengstorf jlengstorf mentioned this issue Feb 26, 2018
Closed
jlengstorf added a commit that referenced this issue Mar 6, 2018
@jlengstorf
fix: allow gramps() calls with no options
e01fc59 
- Remove rest/spread for `gramps()` args
- Add single options object with a default

close #81, close #84
@jlengstorf jlengstorf linked a pull request Mar 6, 2018 that will close this issue
Open
@ryanomackey
Copy link
Member

Looks like that wasn't the actual issue. I was just running node 6.9.5. Would it make sense to include an engines field in the package.json? And maybe a prerequisite in the docs?

@jlengstorf
Copy link
Member Author

jlengstorf commented Mar 7, 2018 via email •
edited by ecwyne
Loading

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: allow gramps() calls with no options gramps-graphql/gramps--legacy
2 participants
@jlengstorf @ryanomackey