fix(AIP-158): reference resource plural for field name #1158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toumorokoshi
approved these changes
May 26, 2023
| if res := utils.GetResource(firstField.GetMessageType()); res != nil && res.GetPlural() != "" { | ||
| want = strcase.SnakeCase(res.GetPlural()) | ||
| } else { | ||
| want = utils.ToPlural(firstField.GetName()) |
There was a problem hiding this comment.
this already existed of course, but I feel like pluralizing the resource singular or the type would be more robust than the field name.
There was a problem hiding this comment.
I think this is meant to support the scenario where the paginated field isn't a resource. I agree with you, but I don't know if we should change it right now. There are maybe one or two Standard List-like fields that paginate a repeated string field that I know of. This rule being in AIP-158, not AIP-132 is poignant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we start to require
pluralingoogle.api.resource, we should referencing it in rules that attempt to pluralize words for things like field names or collection IDs. This is a reasonable heuristic to use for the AIP-158response-plural-first-fieldwhen that first field is a resource.Fixes http://b/271479822