Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CreateOrUpdateCustomPropertyValues for repositories #3105

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Add CreateOrUpdateCustomPropertyValues for repositories #3105

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
8a8247c
Update openapi_operations.yaml using script/metadata.sh
HariCharanK Mar 15, 2024
aeb7f04
Update deprecated endpoint used in ListEnvVariables in action_variabl…
HariCharanK Mar 16, 2024
28db042
Update deprecated endpoint used in GetEnvVariable in action_variables.go
HariCharanK Mar 16, 2024
0d180a4
Update deprecated API used in CreateEnvVariable in actions_variables.go
HariCharanK Mar 16, 2024
05e4b81
Update deprecated API used in UpdateEnvVariable in actions_variables.go
HariCharanK Mar 16, 2024
3475928
Update deprecated API used in DeleteEnvVariable in actions_variables.go
HariCharanK Mar 16, 2024
eefe111
Update generated files using script/generate.sh
HariCharanK Mar 16, 2024
1324e5e
Add CreateOrUpdateCustomPropertyValues for repositories
HariCharanK Mar 16, 2024
7f7d56a
remove language /en path from endpoint URL
HariCharanK Mar 16, 2024
e581a20
Merge branch 'master' into haricharan2
HariCharanK Apr 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions github/repos_properties.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,19 @@ import (
"fmt"
)

// RepoCustomProperty represents an organization custom property object, value can be string, array of strings or null
type RepoCustomProperty struct {
PropertyName string `json:"property_name"`
PropertyValue interface{} `json:"value"`
}

// GetAllCustomPropertyValues gets all custom property values that are set for a repository.
//
// GitHub API docs: https://docs.github.com/rest/repos/custom-properties#get-all-custom-property-values-for-a-repository
//
//meta:operation GET /repos/{owner}/{repo}/properties/values
func (s *RepositoriesService) GetAllCustomPropertyValues(ctx context.Context, org, repo string) ([]*CustomPropertyValue, *Response, error) {
u := fmt.Sprintf("repos/%v/%v/properties/values", org, repo)
func (s *RepositoriesService) GetAllCustomPropertyValues(ctx context.Context, owner, repo string) ([]*CustomPropertyValue, *Response, error) {
u := fmt.Sprintf("repos/%v/%v/properties/values", owner, repo)

req, err := s.client.NewRequest("GET", u, nil)
if err != nil {
Expand All @@ -37,13 +43,13 @@ func (s *RepositoriesService) GetAllCustomPropertyValues(ctx context.Context, or
// GitHub API docs: https://docs.github.com/rest/repos/custom-properties#create-or-update-custom-property-values-for-a-repository
//
//meta:operation PATCH /repos/{owner}/{repo}/properties/values
func (s *RepositoriesService) CreateOrUpdateCustomProperties(ctx context.Context, org, repo string, customPropertyValues []*CustomPropertyValue) (*Response, error) {
func (s *RepositoriesService) CreateOrUpdateCustomProperties(ctx context.Context, org, repo string, customPropertyValues []*RepoCustomProperty) (*Response, error) {
u := fmt.Sprintf("repos/%v/%v/properties/values", org, repo)

params := struct {
Properties []*CustomPropertyValue `json:"properties"`
CustomPropertyValues []*RepoCustomProperty `json:"properties"`
}{
Properties: customPropertyValues,
CustomPropertyValues: customPropertyValues,
}

req, err := s.client.NewRequest("PATCH", u, params)
Expand Down
12 changes: 6 additions & 6 deletions github/repos_properties_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ func TestRepositoriesService_GetAllCustomPropertyValues(t *testing.T) {
client, mux, _, teardown := setup()
defer teardown()

mux.HandleFunc("/repos/o/r/properties/values", func(w http.ResponseWriter, r *http.Request) {
mux.HandleFunc("/repos/usr/r/properties/values", func(w http.ResponseWriter, r *http.Request) {
testMethod(t, r, "GET")
fmt.Fprint(w, `[
{
Expand All @@ -33,7 +33,7 @@ func TestRepositoriesService_GetAllCustomPropertyValues(t *testing.T) {
})

ctx := context.Background()
customPropertyValues, _, err := client.Repositories.GetAllCustomPropertyValues(ctx, "o", "r")
customPropertyValues, _, err := client.Repositories.GetAllCustomPropertyValues(ctx, "usr", "r")
if err != nil {
t.Errorf("Repositories.GetAllCustomPropertyValues returned error: %v", err)
}
Expand All @@ -56,7 +56,7 @@ func TestRepositoriesService_GetAllCustomPropertyValues(t *testing.T) {
const methodName = "GetAllCustomPropertyValues"

testNewRequestAndDoFailure(t, methodName, client, func() (*Response, error) {
got, resp, err := client.Repositories.GetAllCustomPropertyValues(ctx, "o", "r")
got, resp, err := client.Repositories.GetAllCustomPropertyValues(ctx, "usr", "r")
if got != nil {
t.Errorf("testNewRequestAndDoFailure %v = %#v, want nil", methodName, got)
}
Expand All @@ -74,10 +74,10 @@ func TestRepositoriesService_CreateOrUpdateCustomProperties(t *testing.T) {
})

ctx := context.Background()
RepoCustomProperty := []*CustomPropertyValue{
RepoCustomProperty := []*RepoCustomProperty{
{
PropertyName: "environment",
Value: String("production"),
PropertyName: "environment",
PropertyValue: "production",
},
}
_, err := client.Repositories.CreateOrUpdateCustomProperties(ctx, "usr", "r", RepoCustomProperty)
Expand Down
Loading