-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CreateOrUpdateCustomPropertyValues for repositories #3105
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3105 +/- ##
==========================================
- Coverage 97.72% 92.88% -4.84%
==========================================
Files 153 170 +17
Lines 13390 11426 -1964
==========================================
- Hits 13085 10613 -2472
- Misses 215 723 +508
Partials 90 90 ☔ View full report in Codecov by Sentry. |
If you could revert all the changes that are already covered by #3104, that would be great. Just a heads-up... we try to avoid using |
The changes in this depend on changes in #3104, so we should wait until it's merged. I don't see otherwise. " |
resolved merge conflicts. |
@HariCharan-001 - as far as I can tell, this PR is not addressing the issue in #3101 which is to add a PATCH endpoint for this: https://docs.github.com/en/rest/repos/custom-properties?apiVersion=2022-11-28#create-or-update-custom-property-values-for-a-repository |
@gmlewis Do you think it is necessary to avoid using interface{} in this particular scenario ? |
The |
Fixes:
#3101
Followup PR to #3104
Used
interface{}
type forPropertyValue
as it can be string, array or null according to the GitHub documentation here.In Go, an
interface{}
can hold any type, including an array (or slice) of strings.