Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Update deprecated endpoints in github/action_variables.go #3104

Merged
merged 7 commits into from
Mar 28, 2024

Conversation

HariCharanK
Copy link
Contributor

@HariCharanK HariCharanK commented Mar 16, 2024

Fixes:
#3103

BREAKING-CHANGE: The following endpoints now take owner and repo names instead of an integer repo ID:

  • ActionsService.ListEnvVariables
  • ActionsService.GetEnvVariable
  • ActionsService.CreateEnvVariable
  • ActionsService.UpdateEnvVariable
  • ActionsService.DeleteEnvVariable

Copy link

codecov bot commented Mar 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.87%. Comparing base (2b8c7fa) to head (eefe111).
Report is 23 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3104      +/-   ##
==========================================
- Coverage   97.72%   92.87%   -4.86%     
==========================================
  Files         153      170      +17     
  Lines       13390    11403    -1987     
==========================================
- Hits        13085    10590    -2495     
- Misses        215      723     +508     
  Partials       90       90              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gmlewis gmlewis added NeedsReview PR is awaiting a review before merging. Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s). labels Mar 16, 2024
@gmlewis gmlewis changed the title Update deprecated endpoints in github/action_variables.go feat!: Update deprecated endpoints in github/action_variables.go Mar 16, 2024
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @HariCharan-001 !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

@HariCharanK
Copy link
Contributor Author

Hi @gmlewis
The second approval is still pending. Just letting you know, in case.

Can you tag anyone you know ?

@gmlewis
Copy link
Collaborator

gmlewis commented Mar 20, 2024

I try to not bother volunteers since this repo has a rather high traffic of PRs (in my opinion).
Feel free to ask any developer you know to provide a code review.

@gmlewis
Copy link
Collaborator

gmlewis commented Mar 28, 2024

This is holding up other PRs like #3109.
Merging.

@gmlewis gmlewis merged commit 8c1032a into google:master Mar 28, 2024
6 of 7 checks passed
@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants