Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add instruction annotations to the basic block representations. #92

Merged
merged 4 commits into from
Jul 22, 2024
Merged

Add instruction annotations to the basic block representations. #92

merged 4 commits into from
Jul 22, 2024

Commits on Mar 26, 2024

  1. Add instruction annotation message to proto specification. 

     * Add new message type `AnnotationProto`
   (`gematria/proto/annotation.proto`).
 * Include it `CanonicalizedInstructionProto`.
    @virajbshah
    virajbshah committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    fe0b7f3 View commit details
    Browse the repository at this point in the history

  2. Add instruction annotation support to basic block representation. 

     * Add new `Annotation` class.
 * Add `instruction_annotations` vector to `Instruction`.
 * Add Python bindings for these.
 * Add tests for all above changes.
    @virajbshah
    virajbshah committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    63a914f View commit details
    Browse the repository at this point in the history

  3. Add conversions between Annotation and AnnotationProto and back. 

     * Add `Annotation` conversion and update `Instruction` conversion.
 * Refactor `ToVector` and `ToRepeatedPtrField` to be generic.
 * Add Python bindings for conversions.
 * Add tests for all changes.
    @virajbshah
    virajbshah committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    aafb571 View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2024

  1. Address reviewer comments. 

     * Fix a bug in the Python `Annotation` constructor.
 * Make some other minor changes.
    @virajbshah
    virajbshah committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    5d88e8e View commit details
    Browse the repository at this point in the history