Add instruction annotations to the basic block representations. #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add new message type `AnnotationProto` (`gematria/proto/annotation.proto`). * Include it `CanonicalizedInstructionProto`.
* Add new `Annotation` class. * Add `instruction_annotations` vector to `Instruction`. * Add Python bindings for these. * Add tests for all above changes.
* Add `Annotation` conversion and update `Instruction` conversion. * Refactor `ToVector` and `ToRepeatedPtrField` to be generic. * Add Python bindings for conversions. * Add tests for all changes.
ondrasej
approved these changes
Apr 26, 2024
* Fix a bug in the Python `Annotation` constructor. * Make some other minor changes.
ondrasej
approved these changes
May 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds instruction annotations to the proto specification (
AnnotationProto) , the graph builder basic block representation (Annotation), and functions to convert between the two (AnnotationFromProtoandProtoFromAnnotation).