Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demonstrate broken C++ codegen with keywords #8352

Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions scripts/generate_code.py
Original file line number Diff line number Diff line change
Expand Up @@ -392,6 +392,7 @@ def glob(path, pattern):

# Generate the keywords tests
flatc(BASE_OPTS + CS_OPTS, schema="keyword_test.fbs")
flatc(CPP_OPTS, schema="keyword_test.fbs")
flatc(RUST_OPTS, prefix="keyword_test", schema="keyword_test.fbs")
flatc(
BASE_OPTS + CS_OPTS + ["--cs-global-alias", "--gen-onefile"],
Expand Down
6 changes: 6 additions & 0 deletions tests/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,7 @@ cc_test(
deps = [
":alignment_test_cc_fbs",
":arrays_test_cc_fbs",
":keyword_test_cc_fbs",
":monster_extra_cc_fbs",
":monster_test_cc_fbs",
":native_type_test_cc_fbs",
Expand Down Expand Up @@ -241,6 +242,11 @@ flatbuffer_cc_library(
srcs = ["monster_extra.fbs"],
)

flatbuffer_cc_library(
name = "keyword_test_cc_fbs",
srcs = ["keyword_test.fbs"],
)

flatbuffer_cc_library(
name = "arrays_test_cc_fbs",
srcs = ["arrays_test.fbs"],
Expand Down
1 change: 1 addition & 0 deletions tests/test.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@
#include "fuzz_test.h"
#include "json_test.h"
#include "key_field_test.h"
#include "keyword_test_generated.h"
#include "monster_test.h"
#include "monster_test_generated.h"
#include "native_inline_table_test_generated.h"
Expand Down
Loading