Demonstrate broken C++ codegen with keywords #8352
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was checking some robustness of the C++ codegen to keywords around Union types in particular and ran into some issues. Creating this commit to document the presence of issues; I may or may not get around to trying to address this myself. I don't have a strong need for support for this to be fixed myself.
|
Eh, just going to close this and use #8353 to document the issue. I don't think I'll get to fixing this up any time soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was checking some robustness of the C++ codegen to keywords around Union types in particular and ran into some issues. Creating this commit to document the presence of issues; I may or may not get around to trying to address this myself. I don't have a strong need for support for this to be fixed myself.
I don't mind closing this PR to keep the backlog clean; I will create an issue once I have satisfied myself that this is indeed an issue and not just me doing something wrong.