Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add italian and bulgarian translation #1270

Merged
merged 5 commits into from
Jun 24, 2024

Conversation

BlueButterflies
Copy link
Contributor

Hi, I added translation in Italian and Bulgarian languages.

Thank you in advance

@BlueButterflies BlueButterflies requested a review from a team as a code owner May 22, 2024 08:57
@BlueButterflies
Copy link
Contributor Author

BlueButterflies commented Jun 4, 2024

Hi everyone I added translation in Italian and Bulgarian languages.

Thank you in advance

@BlueButterflies
Copy link
Contributor Author

I don't understand where is the problem .

@ahpook
Copy link
Contributor

ahpook commented Jun 15, 2024

/home/runner/work/opensourcefriday/opensourcefriday/vendor/gems/ruby/3.1.0/gems/safe_yaml-1.0.5/lib/safe_yaml/load.rb:143:in `parse': (/home/runner/work/opensourcefriday/opensourcefriday/_data/locales/it.yml): did not find expected key while parsing a block mapping at line 103 column 7 (Psych::SyntaxError)

I ran the file through yamlpp-highlight and found the error. There is an ' in line 105 that makes the parse fail - can you change this to a ʼ (UTF-8 apostrophe)?

    Will_Norris:
      title: "Open Source su <a href='https://github.com/google'>Google</a>"
      name: "Will Norris"
      message: 'Contribuire a progetti open source continua a essere uno dei progetti più apprezzati dal 20% degli ingegneri di Google. L'open source svolge un ruolo così importante in gran parte di ciò che facciamo, quindi cerchiamo di rendere <a href="https://opensource.google.com/docs/patching/"> il processo</a> il più semplice possibile possibile.'

@ahpook
Copy link
Contributor

ahpook commented Jun 15, 2024

A couple of the other message keys also have ' characters that will cause the same problem.

It is because the whole YAML value is wrapped in a single quote message: 'the message here' - but when the content also has a ', YAML thinks the value is closed: message: 'L'open source will only see L , and then start parsing the next key at open. Using a will get around the problem, and will let the embedded URLs parse correctly too.

Copy link
Contributor

@ahpook ahpook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will permit the tests to pass.

_data/locales/it.yml Outdated Show resolved Hide resolved
_data/locales/it.yml Outdated Show resolved Hide resolved
_data/locales/it.yml Outdated Show resolved Hide resolved
_data/locales/it.yml Outdated Show resolved Hide resolved
@BlueButterflies
Copy link
Contributor Author

I apologize for the delay. I made the requested changes.

@ahpook
Copy link
Contributor

ahpook commented Jun 24, 2024

Excellent, looks like all the tests are passing now. Thank you for all this work @BlueButterflies !

@ahpook ahpook merged commit 4912013 into github:main Jun 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants