PART 2:use-github-storage option validation
#1270
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
begonaguereca
changed the title
use-github-storage option validation
Unit Test Results812 tests 812 ✅ 22s ⏱️ Results for commit 5d36e96. |
|
6 tasks
begonaguereca
changed the base branch from
main
to
git-storage-option-feature
Comment on lines
+163
to
+166
| if (UseGithubStorage && AwsBucketName.HasValue()) | ||
| { | ||
| throw new OctoshiftCliException("The --use-github-storage flag was provided with an AWS S3 Bucket name. Archive cannot be uploaded to both locations."); | ||
| } |
There was a problem hiding this comment.
I guess we also need a check for when --use-github-storage is provided with AzureStorageConnectionString
Comment on lines
+71
to
+73
| if (AwsBucketName.HasValue() && UseGithubStorage) | ||
| { | ||
| throw new OctoshiftCliException("The --use-github-storage flag was provided with an AWS S3 Bucket name. Archive cannot be uploaded to both locations."); |
There was a problem hiding this comment.
I guess we also need a check for when --use-github-storage is provided with AzureStorageConnectionString
| ArchivePath = ARCHIVE_PATH, | ||
| GithubOrg = GITHUB_ORG, | ||
| GithubRepo = GITHUB_REPO, | ||
| AzureStorageConnectionString = AZURE_STORAGE_CONNECTION_STRING, |
There was a problem hiding this comment.
Azure storage connection string shouldn't be provided along with aws bucket name. We probably need and extra validation for when both aws and azure options are provided together but probably it'd be a scope creep for this PR. I guess we need to create a ticket to revise our validations and add missing ones.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request ensures proper validation of the
--use-github-storageoption.Closes: https://github.ghe.com/github/octoshift/issues/9326
ThirdPartyNotices.txt(if applicable)