-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PART1: Add use-github-storage
option
#1269
Conversation
Unit Test Results810 tests 810 ✅ 22s ⏱️ Results for commit 781b6de. |
use-github-storage
optionuse-github-storage
option
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new option needs to be added to the command args class for both gei
and bbs2gh
plus some validations.
@@ -191,6 +192,10 @@ public MigrateRepoCommand() : base( | |||
name: "--no-ssl-verify", | |||
description: "Disables SSL verification when communicating with your Bitbucket Server/Data Center instance. All other migration steps will continue to verify SSL. " + | |||
"If your Bitbucket instance has a self-signed SSL certificate then setting this flag will allow the migration archive to be exported."); | |||
public Option<bool> UseGithubStorage { get; } = new( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UseGithubStorage
property also needs to be added to MigrateRepoCommandArgs plus some validations. For example it cannot be provide with both Azure storage connection string or AWS s3 stuff.
Co-authored-by: Arin Ghazarian <[email protected]>
Co-authored-by: Arin Ghazarian <[email protected]>
Breaking up larger PR into smaller chunks. Using @hfishback01 as a feature branch.
The feature will introduce the ability for the GEI CLI to upload archives to GitHub-owned storage using multipart uploads.
To enable this, a new CLI option,
--use-github-storage
, has been added. This option allows users to explicitly specify that their archives should be uploaded to GitHub's managed storage instead of their own.Closes: https://github.ghe.com/github/octoshift/issues/9321
ThirdPartyNotices.txt
(if applicable)