PART1: Add use-github-storage option
#1269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit Test Results810 tests 810 ✅ 22s ⏱️ Results for commit 781b6de. |
|
begonaguereca
changed the title
use-github-storage optionuse-github-storage option
begonaguereca
changed the base branch from
git-storage-option
to
git-storage-option-feature
ArinGhazarian
requested changes
Sep 27, 2024
| @@ -191,6 +192,10 @@ public MigrateRepoCommand() : base( | |||
| name: "--no-ssl-verify", | |||
| description: "Disables SSL verification when communicating with your Bitbucket Server/Data Center instance. All other migration steps will continue to verify SSL. " + | |||
| "If your Bitbucket instance has a self-signed SSL certificate then setting this flag will allow the migration archive to be exported."); | |||
| public Option<bool> UseGithubStorage { get; } = new( | |||
There was a problem hiding this comment.
UseGithubStorage property also needs to be added to MigrateRepoCommandArgs plus some validations. For example it cannot be provide with both Azure storage connection string or AWS s3 stuff.
Co-authored-by: Arin Ghazarian <[email protected]>
Co-authored-by: Arin Ghazarian <[email protected]>
ArinGhazarian
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking up larger PR into smaller chunks. Using @hfishback01 as a feature branch.
The feature will introduce the ability for the GEI CLI to upload archives to GitHub-owned storage using multipart uploads.
To enable this, a new CLI option,
--use-github-storage, has been added. This option allows users to explicitly specify that their archives should be uploaded to GitHub's managed storage instead of their own.Closes: https://github.ghe.com/github/octoshift/issues/9321
ThirdPartyNotices.txt(if applicable)