Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PART1: Add use-github-storage option #1269

Merged
merged 3 commits into from
Sep 27, 2024

Conversation

begonaguereca
Copy link
Contributor

@begonaguereca begonaguereca commented Sep 25, 2024

Breaking up larger PR into smaller chunks. Using @hfishback01 as a feature branch.

The feature will introduce the ability for the GEI CLI to upload archives to GitHub-owned storage using multipart uploads.

To enable this, a new CLI option, --use-github-storage, has been added. This option allows users to explicitly specify that their archives should be uploaded to GitHub's managed storage instead of their own.

Closes: https://github.ghe.com/github/octoshift/issues/9321

  • Did you write/update appropriate tests
  • Release notes updated (if appropriate)
  • Appropriate logging output
  • Issue linked
  • Docs updated (or issue created)
  • New package licenses are added to ThirdPartyNotices.txt (if applicable)

@begonaguereca begonaguereca changed the base branch from main to git-storage-option September 25, 2024 14:11
Copy link

Unit Test Results

810 tests   810 ✅  22s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit 781b6de.

Copy link

Code Coverage

Package Line Rate Branch Rate Complexity Health
bbs2gh 79% 73% 652
ado2gh 84% 78% 627
Octoshift 87% 76% 1272
gei 79% 70% 520
Summary 83% (6832 / 8183) 75% (1534 / 2044) 3071

@begonaguereca begonaguereca changed the title Add use-github-storage option PART1: Add use-github-storage option Sep 25, 2024
@begonaguereca begonaguereca changed the base branch from git-storage-option to git-storage-option-feature September 27, 2024 18:30
@begonaguereca begonaguereca marked this pull request as ready for review September 27, 2024 18:30
Copy link
Collaborator

@ArinGhazarian ArinGhazarian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new option needs to be added to the command args class for both gei and bbs2gh plus some validations.

src/bbs2gh/Commands/MigrateRepo/MigrateRepoCommand.cs Outdated Show resolved Hide resolved
src/gei/Commands/MigrateRepo/MigrateRepoCommand.cs Outdated Show resolved Hide resolved
@@ -191,6 +192,10 @@ public MigrateRepoCommand() : base(
name: "--no-ssl-verify",
description: "Disables SSL verification when communicating with your Bitbucket Server/Data Center instance. All other migration steps will continue to verify SSL. " +
"If your Bitbucket instance has a self-signed SSL certificate then setting this flag will allow the migration archive to be exported.");
public Option<bool> UseGithubStorage { get; } = new(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UseGithubStorage property also needs to be added to MigrateRepoCommandArgs plus some validations. For example it cannot be provide with both Azure storage connection string or AWS s3 stuff.

@begonaguereca begonaguereca merged commit 1a5e198 into git-storage-option-feature Sep 27, 2024
@begonaguereca begonaguereca deleted the gso-option branch September 27, 2024 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants