Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING CHANGE: Drop support for deprecated --wait option in migrate-repo and migrate-org #1083

Merged
merged 5 commits into from
Aug 2, 2023

Commits on Jul 25, 2023

  1. BREAKING CHANGE: Drop support for deprecated --wait option in `migr…

    …ate-repo` and `migrate-org`
    
    Up until April, the default behavior of `migrate-repo` and
    `migrate-org` was to exit immediately after queueing the
    migration, and not to wait for it to complete. Users could opt
    in to the "wait" behaviour using the `--wait` option.
    
    In April, we [flipped][1] these defaults around, making waiting
    the default and adding the `--queue-only` option for the old
    behavior.
    
    This meant that the `--wait` option could go away - but we wanted
    to do this in a user-friendly, backwards-compatible way.
    
    At that time, we deprecated the `--wait` option, hiding it from
    the in-CLI documentation and printing warning when it's used.
    These warnings have been in place for 3 months, so now is a
    reasonable time to rip off the band aid and remove the argument.
    
    After this change is released, specifying the old `--wait` option
    will cause the CLI to error.
    
    Fixes #1082 and
    #1059.
    
    [1]: #929
    timrogers committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    0bfb32f View commit details
    Browse the repository at this point in the history
  2. Add trailing commas in tests

    Co-authored-by: Dylan Smith <[email protected]>
    timrogers and dylan-smith authored Jul 25, 2023
    Configuration menu
    Copy the full SHA
    1c8b08b View commit details
    Browse the repository at this point in the history
  3. Add back lost test

    timrogers committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    9be9440 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2023

  1. Configuration menu
    Copy the full SHA
    4cc4aa0 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2023

  1. Update RELEASENOTES.md

    Co-authored-by: Maxwell Pray <[email protected]>
    timrogers and synthead authored Aug 2, 2023
    Configuration menu
    Copy the full SHA
    f918b2f View commit details
    Browse the repository at this point in the history