BREAKING CHANGE: Drop support for deprecated --wait option in migrate-repo and migrate-org
#1083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ate-repo` and `migrate-org` Up until April, the default behavior of `migrate-repo` and `migrate-org` was to exit immediately after queueing the migration, and not to wait for it to complete. Users could opt in to the "wait" behaviour using the `--wait` option. In April, we [flipped][1] these defaults around, making waiting the default and adding the `--queue-only` option for the old behavior. This meant that the `--wait` option could go away - but we wanted to do this in a user-friendly, backwards-compatible way. At that time, we deprecated the `--wait` option, hiding it from the in-CLI documentation and printing warning when it's used. These warnings have been in place for 3 months, so now is a reasonable time to rip off the band aid and remove the argument. After this change is released, specifying the old `--wait` option will cause the CLI to error. Fixes #1082 and #1059. [1]: #929
dylan-smith
reviewed
Jul 25, 2023
src/OctoshiftCLI.Tests/ado2gh/Commands/MigrateRepo/MigrateRepoCommandHandlerTests.cs
Outdated
Show resolved
Hide resolved
dylan-smith
reviewed
Jul 25, 2023
src/OctoshiftCLI.Tests/ado2gh/Commands/MigrateRepo/MigrateRepoCommandHandlerTests.cs
Outdated
Show resolved
Hide resolved
dylan-smith
reviewed
Jul 25, 2023
src/OctoshiftCLI.Tests/ado2gh/Commands/MigrateRepo/MigrateRepoCommandHandlerTests.cs
Outdated
Show resolved
Hide resolved
dylan-smith
reviewed
Jul 25, 2023
src/OctoshiftCLI.Tests/bbs2gh/Commands/MigrateRepo/MigrateRepoCommandHandlerTests.cs
Outdated
Show resolved
Hide resolved
dylan-smith
reviewed
Jul 25, 2023
src/OctoshiftCLI.Tests/ado2gh/Commands/MigrateRepo/MigrateRepoCommandTests.cs
Outdated
Show resolved
Hide resolved
dylan-smith
reviewed
Jul 25, 2023
src/OctoshiftCLI.Tests/gei/Commands/MigrateOrg/MigrateOrgCommandArgsTests.cs
Outdated
Show resolved
Hide resolved
dylan-smith
reviewed
Jul 25, 2023
src/OctoshiftCLI.Tests/gei/Commands/MigrateOrg/MigrateOrgCommandHandlerTests.cs
Outdated
Show resolved
Hide resolved
dylan-smith
reviewed
Jul 25, 2023
src/OctoshiftCLI.Tests/gei/Commands/MigrateOrg/MigrateOrgCommandHandlerTests.cs
Outdated
Show resolved
Hide resolved
dylan-smith
reviewed
Jul 25, 2023
src/OctoshiftCLI.Tests/gei/Commands/MigrateRepo/MigrateRepoCommandArgsTests.cs
Outdated
Show resolved
Hide resolved
dylan-smith
reviewed
Jul 25, 2023
src/OctoshiftCLI.Tests/gei/Commands/MigrateRepo/MigrateRepoCommandHandlerTests.cs
Outdated
Show resolved
Hide resolved
dylan-smith
reviewed
Jul 25, 2023
src/OctoshiftCLI.Tests/gei/Commands/MigrateRepo/MigrateRepoCommandHandlerTests.cs
Outdated
Show resolved
Hide resolved
dylan-smith
reviewed
Jul 25, 2023
src/OctoshiftCLI.Tests/gei/Commands/MigrateRepo/MigrateRepoCommandHandlerTests.cs
Outdated
Show resolved
Hide resolved
dylan-smith
reviewed
Jul 25, 2023
src/OctoshiftCLI.Tests/gei/Commands/MigrateRepo/MigrateRepoCommandHandlerTests.cs
Outdated
Show resolved
Hide resolved
dylan-smith
reviewed
Jul 25, 2023
src/OctoshiftCLI.Tests/gei/Commands/MigrateRepo/MigrateRepoCommandHandlerTests.cs
Outdated
Show resolved
Hide resolved
dylan-smith
reviewed
Jul 25, 2023
src/OctoshiftCLI.Tests/gei/Commands/MigrateRepo/MigrateRepoCommandHandlerTests.cs
Outdated
Show resolved
Hide resolved
dylan-smith
reviewed
Jul 25, 2023
src/OctoshiftCLI.Tests/gei/Commands/MigrateRepo/MigrateRepoCommandHandlerTests.cs
Outdated
Show resolved
Hide resolved
dylan-smith
reviewed
Jul 25, 2023
src/OctoshiftCLI.Tests/gei/Commands/MigrateRepo/MigrateRepoCommandHandlerTests.cs
Outdated
Show resolved
Hide resolved
dylan-smith
reviewed
Jul 25, 2023
src/OctoshiftCLI.Tests/gei/Commands/MigrateRepo/MigrateRepoCommandHandlerTests.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Dylan Smith <[email protected]>
Thanks @dylan-smith for the [great spot][1]! [1]: https://github.com/github/gh-gei/pull/1083/files#r1273783346
synthead
reviewed
Aug 2, 2023
Co-authored-by: Maxwell Pray <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up until April, the default behavior of
migrate-repoandmigrate-orgwas to exit immediately after queueing the migration, and not to wait for it to complete. Users could opt in to the "wait" behaviour using the--waitoption.In April, we flipped these defaults around, making waiting the default and adding the
--queue-onlyoption for the old behavior.This meant that the
--waitoption could go away - but we wanted to do this in a user-friendly, backwards-compatible way.At that time, we deprecated the
--waitoption, hiding it from the in-CLI documentation and printing warning when it's used. These warnings have been in place for 3 months, so now is a reasonable time to rip off the band aid and remove the argument.After this change is released, specifying the old
--waitoption will cause the CLI to error.Fixes #1082 and #1059.
ThirdPartyNotices.txt(if applicable)