Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(transactions): dont send transactions to post_process #81085

Closed
wants to merge 4 commits into from

Conversation

JoshFerge
Copy link
Member

@JoshFerge JoshFerge commented Nov 20, 2024

Once we've deployed #81079, we no longer need to send transactions to post_process.

We delete the redis key from the processing store right in save event as its no longer needed, and take advantage of the existing raw / skip_consume functionality to tell the event stream not to carry on the transaction to post_process after it's been inserted into snuba.

skip_consume=job.get("raw", False),

Once this is merged and the option is turned on, we can delete all of the option code, as well as code that is no longer active in post_process.

part of #81065

note that when this is deployed, there could be some transactions that go through post_process that do not have values in the processing store. this shouldn't cause problems, and wil monitor logs from post_process here:

"post_process.skipped",

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Nov 20, 2024
@JoshFerge JoshFerge marked this pull request as ready for review November 20, 2024 23:16
@JoshFerge JoshFerge requested review from a team as code owners November 20, 2024 23:16
@JoshFerge JoshFerge requested review from a team, lynnagara and markstory November 20, 2024 23:17
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/sentry/tasks/store.py 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                     Coverage Diff                      @@
##           jferg/tx-post-process-1   #81085       +/-   ##
============================================================
+ Coverage                    57.52%   78.48%   +20.95%     
============================================================
  Files                         7204     7215       +11     
  Lines                       319305   319819      +514     
  Branches                     43991    44047       +56     
============================================================
+ Hits                        183686   251003    +67317     
+ Misses                      130864    62421    -68443     
- Partials                      4755     6395     +1640     

@JoshFerge JoshFerge force-pushed the jferg/tx-post-process-2 branch 3 times, most recently from f89cfd2 to 1505605 Compare November 21, 2024 15:09
transaction_processed_signal_mock: mock.MagicMock,
mock_record_sample: mock.MagicMock,
eventstream_insert: mock.MagicMock,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you missing a patch()?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah yes, thank you. fixed.

@JoshFerge
Copy link
Member Author

rollout strategy:
#81065 (comment)

Copy link
Member Author

@JoshFerge JoshFerge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: split this up into two separate options as well.

@JoshFerge
Copy link
Member Author

closing this PR as per #81077 (comment), we've decided to not modify post_process as all for this change. deletion from rc processing consolidated into the same option as the rest of the changes.

@JoshFerge JoshFerge closed this Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants