Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(transactions): clean up post_process transactions areas #81091

Draft
wants to merge 4 commits into
base: jferg/tx-post-process-3
Choose a base branch
from

Conversation

JoshFerge
Copy link
Member

@JoshFerge JoshFerge commented Nov 20, 2024

after we deploy #81085 and validate all is well, we can clean up the options used to deploy the feature, and delete code in post_process to do with transactions.

final step of #81065

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Nov 20, 2024
Copy link

codecov bot commented Nov 20, 2024

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
23108 2 23106 215
View the top 2 failed tests by shortest run time
tests.sentry.tasks.test_store::test_store_consumer_type
Stack Traces | 2.48s run time
#x1B[1m#x1B[.../sentry/tasks/test_store.py#x1B[0m:400: in test_store_consumer_type
    mock_transaction_processing_store.delete_by_key.assert_not_called()
#x1B[1m#x1B[.../hostedtoolcache/Python/3.12.6.../x64/lib/python3.12/unittest/mock.py#x1B[0m:908: in assert_not_called
    raise AssertionError(msg)
#x1B[1m#x1B[31mE   AssertionError: Expected 'delete_by_key' to not have been called. Called 1 times.#x1B[0m
#x1B[1m#x1B[31mE   Calls: [call('tx:3')].#x1B[0m
tests.sentry.event_manager.test_event_manager.EventManagerTest::test_transaction_sampler_and_recieve_mock_called
Stack Traces | 4.33s run time
#x1B[1m#x1B[.../sentry/event_manager/test_event_manager.py#x1B[0m:1665: in test_transaction_sampler_and_recieve_mock_called
    assert mock_record_sample.mock_calls == [
#x1B[1m#x1B[31mE   AssertionError: assert [call(sender=...f0c0bee52e0>)] == [call(<Cluste...672>, 'wait')]#x1B[0m
#x1B[1m#x1B[31mE     #x1B[0m
#x1B[1m#x1B[31mE     At index 0 diff: call(sender=None, project=<Project at 0x7f0c0bad6a50: id=4555081210396674, team_id=None, name='Bar', slug='bar', organization_id=4555081210396672>, event=<sentry.eventstore.models.Event object at 0x7f0c0bee52e0>) != call(<ClustererNamespace.TRANSACTIONS: NamespaceOption(name='transactions', data='txnames2', rules='txrules', persistent_storage='sentry:transaction_name_cluster_rules', tracker='txcluster.rules_per_project', meta_store='sentry:transaction_name_cluster_meta')>, <Project at 0x7f0c14281dc0: id=4555081210396674, team_id=None, name='Bar', slug='bar', organization_id=4555081210396672>, 'wait')#x1B[0m
#x1B[1m#x1B[31mE     #x1B[0m
#x1B[1m#x1B[31mE     Full diff:#x1B[0m
#x1B[1m#x1B[31mE     + [call(sender=None, project=<Project at 0x7f0c0bad6a50: id=4555081210396674, team_id=None, name='Bar', slug='bar', organization_id=4555081210396672>, event=<sentry.eventstore.models.Event object at 0x7f0c0bee52e0>)]#x1B[0m
#x1B[1m#x1B[31mE     - [#x1B[0m
#x1B[1m#x1B[31mE     -     call(<ClustererNamespace.TRANSACTIONS: NamespaceOption(name='transactions', data='txnames2', rules='txrules', persistent_storage='sentry:transaction_name_cluster_rules', tracker='txcluster.rules_per_project', meta_store='sentry:transaction_name_cluster_meta')>, <Project at 0x7f0c14281dc0: id=4555081210396674, team_id=None, name='Bar', slug='bar', organization_id=4555081210396672>, 'wait'),#x1B[0m
#x1B[1m#x1B[31mE     - ]#x1B[0m

To view more test analytics, go to the Test Analytics Dashboard
Got feedback? Let us know on Github

@JoshFerge JoshFerge force-pushed the jferg/tx-post-process-3 branch 5 times, most recently from 41fa796 to 5267ffa Compare November 21, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant