feat: Breadcrumbs on button clicks #864
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| using UnityEditor.Build; | ||
| using UnityEditor.Build.Reporting; | ||
| using UnityEditor.Events; | ||
| using UnityEngine.Events; | ||
| using UnityEngine.SceneManagement; | ||
| using UnityEngine.UI; | ||
|
|
||
| namespace Sentry.Unity.Editor | ||
| { | ||
| public class ButtonInstrumentation : IProcessSceneWithReport | ||
| { | ||
| public int callbackOrder { get; } = 0; | ||
|
|
||
| public void OnProcessScene(Scene scene, BuildReport report) | ||
| { | ||
| var gameObjects = scene.GetRootGameObjects(); | ||
| if (gameObjects is { Length: > 0 }) | ||
| { | ||
| var sentryScene = gameObjects[0].AddComponent<SentryScene>(); | ||
|
|
||
| foreach (var gameObject in gameObjects) | ||
| { | ||
| var buttons = gameObject.GetComponentsInChildren<Button>(); | ||
| foreach (var button in buttons) | ||
| { | ||
| var unityAction = new UnityAction<string>(sentryScene.AddButtonBreadcrumb); | ||
| UnityEventTools.AddStringPersistentListener(button.onClick, unityAction, button.gameObject.name); | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| using UnityEngine; | ||
|
|
||
| namespace Sentry.Unity | ||
| { | ||
| public class SentryScene : MonoBehaviour | ||
|
There was a problem hiding this comment. Adding a callback to a button relies on a MonoBehaviour being a permanent part of the scene. |
||
| { | ||
| public void AddButtonBreadcrumb(string message) | ||
| => SentrySdk.AddBreadcrumb(message, "unity.ui.button"); | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That here needs some cleaning up but the gist of it is:
ManagedPath/UnityEngine.dllon the managed root contains all the type forwarders to the modules inside ofManagedPath/UnityEngine/. This does not seem to work 100% of the time like with LogAssert in the test projs. Instead, we could just reference the individual modules.