feat: Breadcrumbs on button clicks #864
Conversation
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- Breadcrumbs on button clicks ([#864](https://github.com/getsentry/sentry-unity/pull/864))If none of the above apply, you can opt out of this check by adding |
| @@ -43,10 +43,63 @@ | |||
| <Error Condition="'$(UnityManagedPath)' == ''" Text="'UnityManagedPath' not defined. Can't find UnityEngine.dll."></Error> | |||
| <Error Condition="!Exists('$(UnityManagedPath)/UnityEngine.dll')" Text="Couldn't find UnityEngine at $(UnityManagedPath)/UnityEngine.dll."></Error> | |||
| <ItemGroup> | |||
| <!-- <Reference Include="UnityEngine">--> | |||
| <!-- <HintPath>$(UnityManagedPath)/UnityEngine.dll</HintPath>--> | |||
There was a problem hiding this comment.
That here needs some cleaning up but the gist of it is: ManagedPath/UnityEngine.dll on the managed root contains all the type forwarders to the modules inside of ManagedPath/UnityEngine/. This does not seem to work 100% of the time like with LogAssert in the test projs. Instead, we could just reference the individual modules.
|
|
||
| namespace Sentry.Unity | ||
| { | ||
| public class SentryScene : MonoBehaviour |
There was a problem hiding this comment.
Adding a callback to a button relies on a MonoBehaviour being a permanent part of the scene. SentryMonoBehaviour get created during runtime and the callback would fail.
|
This issue has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you remove the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
The idea is to auto-instrument all buttons present in scenes during build time (the
OnProcessScenealso gets called within the Editor).