Feat/native scope observer #546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruno-garcia
reviewed
Feb 4, 2022
vaind
force-pushed
the
feat/native-scope-observer
branch
from
112843b
to
920dc6b
Compare
bruno-garcia
requested changes
Feb 7, 2022
vaind
force-pushed
the
feat/native-scope-observer
branch
from
27a0c9f
to
4738c97
Compare
bruno-garcia
approved these changes
Feb 7, 2022
Co-authored-by: Bruno Garcia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally this was supposed to implement native scope observer (for windows support #527), but I've noticed the scope observer implementations share some code and didn't want to duplicate it further so instead went for a little refactoring.
#skip-changelog
Native crash breadcrumbs shown here: https://sentry.io/organizations/sentry-sdks/issues/2988392337/events/53be944157b54ee59586dbb5f8fdd8c8/?project=5439417