Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Upgrade to go 1.22.2, g/g 1.92.2, and refresh indirect dependencies in go.mod #789

Closed
wants to merge 154 commits into from

Conversation

shreyas-s-rao
Copy link
Contributor

How to categorize this PR?

/area quality dev-productivity
/kind impediment enhancement

What this PR does / why we need it:
Upgrades to go v1.22.2, and updates g/g dependency to v1.92.2 (latest version atm), and fix linter errors.

Additionally, indirect dependency k8s.io/autoscaler was at an old version, and was not compatible with gardener/gardener dependencies, causing improper imports when checking out both etcd-druid and gardener repos on the same machine. This has now been fixed, by refreshing all indirect dependencies, which caused k8s.io/autoscaler to be updated to k8s.io/autoscaler/vertical-pod-autoscaler v1.0.0.

Which issue(s) this PR fixes:
Fixes #778 #788

Special notes for your reviewer:
/hold
To be rebased after #777 is merged.
Ignore all commits expect the last 2, since this PR is based on #777 branch, not master (for ease of rebasing in the future).

Release note:

Upgrade go to v1.22.2.

unmarshall and others added 30 commits April 22, 2024 14:28
Introduced a new `registry` package containing `OperatorRegistry`. Additionally, created a subpackage `registry/resource` contains OperatorContext and Operator interface to address cyclic import issues
- Replaced flow package with OperatorTask in Sync method.
- Enhanced error handling using multierror for aggregating multiple task errors.
@shreyas-s-rao shreyas-s-rao added this to the v0.23.0 milestone Apr 25, 2024
@shreyas-s-rao shreyas-s-rao self-assigned this Apr 25, 2024
Copy link

gardener-prow bot commented Apr 25, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@gardener-robot gardener-robot added the needs/review Needs review label Apr 25, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 25, 2024
@gardener-robot gardener-robot added area/dev-productivity Developer productivity related (how to improve development) area/quality Output qualification (tests, checks, scans, automation in general, etc.) related kind/enhancement Enhancement, improvement, extension kind/impediment Something that impedes developers, operators, users or others in their work reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies labels Apr 25, 2024
Copy link

gitguardian bot commented Apr 25, 2024

⚠️ GitGuardian has uncovered 3 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
- RSA Private Key e2bfea3 charts/druid/resources/server.key View secret
- RSA Private Key e2bfea3 charts/druid/resources/ca.key View secret
- RSA Private Key e2bfea3 charts/druid/templates/secret-server-tls-crt.yaml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@gardener-robot gardener-robot added size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Apr 25, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 25, 2024
@renormalize
Copy link
Member

Note: we could probably just run a regex to find all instances of where a new variable is declared inside the loop to deal with the for loop variable scoping pre go1.22.x.

Regex for word := word.

@renormalize
Copy link
Member

@shreyas-s-rao go1.22.3 got released on 2024-05-07. If it's not too much effort for you, maybe the patch version could be changed from 2 to 3 in this PR to make use of security and bug fixes in the compiler, runtime and net/http.

@shreyas-s-rao
Copy link
Contributor Author

@renormalize thanks for the information. I'll make both the changes you've suggested once #777 gets merged, because I anyway need to do some rebasing at that point of time, so I'll touch the code then.

@renormalize
Copy link
Member

Yeah sure, I was just informing you in advance. Thanks!

@renormalize
Copy link
Member

go1.22.4 has now been released. Once the refactor is merged, we could use go1.22.4 directly in this PR.

@ishan16696
Copy link
Member

Closing this PR in favour of PR: #834
/close

@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dev-productivity Developer productivity related (how to improve development) area/quality Output qualification (tests, checks, scans, automation in general, etc.) related kind/enhancement Enhancement, improvement, extension kind/impediment Something that impedes developers, operators, users or others in their work needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review needs/second-opinion Needs second review by someone else reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade golang version to 1.22
8 participants