Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade golang version to 1.22.2 and remove dependency on g/g scripts #784

Closed
wants to merge 2 commits into from
Closed

Upgrade golang version to 1.22.2 and remove dependency on g/g scripts #784

wants to merge 2 commits into from

Conversation

unmarshall
Copy link
Contributor

@unmarshall unmarshall commented Apr 11, 2024 •
edited
Loading

How to categorize this PR?

How to categorize this PR?

/area control-plane
/kind enhancement

What this PR does / why we need it:

  • Upgrades golang version to 1.22.2
  • Removes dependency on g/g hack/scripts
  • Fixes some flakiness in e2e tests
  • Replace github.com/golang/mock with go.uber.org/mock
  • Upgrade golangci-lint and fix linting errors

Which issue(s) this PR fixes:
Fixes #778, #503

Special notes for your reviewer:

Release note:

etcd-druid now uses golang version 1.22.2
`github.com/golang/mock` is replaced by `go.uber.org/mock` since the former is no longer maintained
upgraded golangci-lint to v1.57.2
simplified hack/scripts and removed dependency on g/g hack/scripts

@unmarshall unmarshall requested a review from a team as a code owner April 11, 2024 17:01
@gardener-robot gardener-robot added the needs/review Needs review label Apr 11, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 11, 2024
@gardener-robot gardener-robot added area/control-plane Control plane related kind/enhancement Enhancement, improvement, extension size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Apr 11, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 11, 2024
@unmarshall
Copy link
Contributor Author

  • make check passes locally
  • make test passes locally
  • make test-integration passes locally
  • make ci-e2e-kind passes locally

@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 11, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 11, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 12, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 12, 2024
@shreyas-s-rao shreyas-s-rao mentioned this pull request Apr 14, 2024
Closed
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 14, 2024
@unmarshall
Copy link
Contributor Author

/test pull-etcd-druid-e2e-kind

@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 14, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 14, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 14, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 14, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 15, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 15, 2024
@unmarshall
Copy link
Contributor Author

/test pull-etcd-druid-e2e-kind

@renormalize
Copy link
Member

/retest

@gardener-prow Gardener Prow
Copy link

gardener-prow bot commented Apr 15, 2024

@unmarshall: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-etcd-druid-e2e-kind 7ab3c1e link true /test pull-etcd-druid-e2e-kind
pull-etcd-druid-e2e-kind-nondistroless-etcd 7ab3c1e link true /test pull-etcd-druid-e2e-kind-nondistroless-etcd

Full PR test history. Your PR dashboard. Command help for this repository.
Please help us cut down on flakes by linking this test failure to an open flake report or filing a new flake report if you can't find an existing one. Also see our testing guideline for how to avoid and hunt flakes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@renormalize
Copy link
Member

Will this PR be closed, or will it be rebased on #748?

@unmarshall
Copy link
Contributor Author

i will break this PR into 2: remove g/g scripts and then change go version. This PR will get closed in favor of new PRs.

@shreyas-s-rao
Copy link
Contributor

/hold

#789 solves the go upgrade part of this PR. Will raise another PR after for removing dependency g/g hack scripts, and then close this PR.

@gardener-robot gardener-robot added the reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies label Apr 25, 2024
@shreyas-s-rao shreyas-s-rao added this to the v0.24.0 milestone Jun 24, 2024
@unmarshall unmarshall closed this by deleting the head repository Jul 9, 2024
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@unmarshall unmarshall

Labels
area/control-plane Control plane related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review needs/second-opinion Needs second review by someone else reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
v0.24.0
Development

Successfully merging this pull request may close these issues.

Upgrade golang version to 1.22
7 participants
@unmarshall @renormalize @shreyas-s-rao @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot