Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed console.log for Slack responses #298

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Removed console.log for Slack responses #298

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion api-module-library/slack/api.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,6 @@ class Api extends OAuth2Requester {
const parsedResponse = await this.parsedBody(response);
const { status } = response;
const { ok, error } = parsedResponse;
console.log(parsedResponse);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mm yeah. Though I think this needs to be based on version-0 and PR'ed into version-0?

@leofmds cc @MichaelRyanWebber

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll do it to version-0 and then v1. Should we still use this repo to update the modules for v1?
@seanspeaks

Copy link
Contributor

@seanspeaks seanspeaks Apr 4, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm 90% sure that any version over 0.x.x goes to api-module-library.

So, this would be a PR into version-0 here and a PR into main over at api-module-library

I also think we should be removing the api-module-library folder from this main, but wanted to double check with @MichaelRyanWebber on that

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leofmds / @MichaelRyanWebber Looping back on this before EOD (I see that you changed the branch back to main after toggling to version-0 @leofmds )


// If the status is retriable and there are back off requests left, retry the request
if ((status === 429 || status >= 500) && i < this.backOff.length) {
Expand Down
Loading