-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed console.log for Slack responses #298
base: main
Are you sure you want to change the base?
Removed console.log for Slack responses #298
Conversation
Quality Gate passedIssues Measures |
@@ -117,7 +117,6 @@ class Api extends OAuth2Requester { | |||
const parsedResponse = await this.parsedBody(response); | |||
const { status } = response; | |||
const { ok, error } = parsedResponse; | |||
console.log(parsedResponse); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mm yeah. Though I think this needs to be based on version-0 and PR'ed into version-0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll do it to version-0 and then v1. Should we still use this repo to update the modules for v1?
@seanspeaks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm 90% sure that any version over 0.x.x
goes to api-module-library.
So, this would be a PR into version-0
here and a PR into main
over at api-module-library
I also think we should be removing the api-module-library folder from this main
, but wanted to double check with @MichaelRyanWebber on that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@leofmds / @MichaelRyanWebber Looping back on this before EOD (I see that you changed the branch back to main
after toggling to version-0
@leofmds )
No description provided.