Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed console.log for Slack responses #298

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

leofmds
Copy link
Contributor

@leofmds leofmds commented Apr 3, 2024

No description provided.

Copy link

linear bot commented Apr 3, 2024

@leofmds leofmds requested a review from seanspeaks April 3, 2024 16:45
Copy link

sonarcloud bot commented Apr 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@@ -117,7 +117,6 @@ class Api extends OAuth2Requester {
const parsedResponse = await this.parsedBody(response);
const { status } = response;
const { ok, error } = parsedResponse;
console.log(parsedResponse);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mm yeah. Though I think this needs to be based on version-0 and PR'ed into version-0?

@leofmds cc @MichaelRyanWebber

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll do it to version-0 and then v1. Should we still use this repo to update the modules for v1?
@seanspeaks

Copy link
Contributor

@seanspeaks seanspeaks Apr 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm 90% sure that any version over 0.x.x goes to api-module-library.

So, this would be a PR into version-0 here and a PR into main over at api-module-library

I also think we should be removing the api-module-library folder from this main, but wanted to double check with @MichaelRyanWebber on that

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leofmds / @MichaelRyanWebber Looping back on this before EOD (I see that you changed the branch back to main after toggling to version-0 @leofmds )

@leofmds leofmds changed the base branch from main to version-0 April 3, 2024 22:21
@leofmds leofmds changed the base branch from version-0 to main April 3, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants