-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable a new payment controller #40845
base: develop
Are you sure you want to change the base?
Conversation
53b1a4d
to
3cbfb81
Compare
2e79642
to
1330761
Compare
This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing. |
cdb0efa
to
662e6a9
Compare
16a104f
to
920743c
Compare
920743c
to
0a8c846
Compare
@s-aga-r From the standpoint of coordinating this PR in connection with it's dependent frappe/payments#53 this PR is fully backwards compatible and should be merged first in order to enable meaningful test execution on frappe/payments#53, at all. Nonwithstanding amendments that will be required to this PR upon further insights gainer through future work on frappe/payments#53, this PR can be deemed at least "ready to review", if not "ready to merge (and iterate later)". I appreciate your (hopeful) help and collaboration. Thank you in advance! |
@s-aga-r Could you help with a commitment to engage on this one? My situation is that I want to contract with a well renown Frappe Partner for custom development and it's absolutely essential for us to be able to leverage the revised payment integration that this PR prepares on the ERPNext side. I promise, I'll leave you alone with my heavy handed contributions for a while after this. Sounds like a deal? 😃 |
@ruthra-kumar can you take this up? |
As long as the changes are small and easy to reason about, I can help with review. @blaggacao This PR is too big to work with. I would suggest breaking it into smaller, atomic changes. |
ah! Ok, this explains all :-) Thanks for your comments in this case. It's marked "Pending" which means it's still in a sort of "staging" area and isn't visible to anyone else other than you. You'd need to click on "Finish your review" or something like that somewhere. |
889c299
to
bcd0bad
Compare
0796d71
to
dc0f213
Compare
dc0f213
to
a734238
Compare
7fdd3ff
to
6f3368b
Compare
6f3368b
to
e799295
Compare
#42160 is necessary to effectively leverage frappe/frappe#25952 for frappe/payments#53 |
e799295
to
14221ed
Compare
14221ed
to
9b61ba7
Compare
9b61ba7
to
24918ae
Compare
Here's a review branch without the preliminary code-shaping: blaggacao#1
no-docs