Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: explicate intent on make_payment_request interface #42393

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

blaggacao
Copy link
Collaborator

@blaggacao blaggacao commented Jul 18, 2024

Next part of #40845

cc @ruthra-kumar

@blaggacao
Copy link
Collaborator Author

You may say Im a dreamer, but Im not the only one, I hope someday you will join us, and the world will live as one. - John Lennon


Kindly help move this PR forward. Many thanks from Yours Sincerely!

@blaggacao
Copy link
Collaborator Author

I have just three things to teach: simplicity, patience, compassion. These three are your greatest treasures. - Lao Tzu


Kindly help move this PR forward. Many thanks from Yours Sincerely!

@blaggacao
Copy link
Collaborator Author

@ruthra-kumar I hope all is well and work not too inundating. Didn't we want to advance on this on some sort of cadence? This is also the last one of the previous refactorings to accommodate the new gatweawy api (which I will restructure in its commit sequence after this). This here is lightwight and - I hope - easy to review. All in all good for an easy "cross-of-the-list reward".

@ruthra-kumar ruthra-kumar merged commit 93ee922 into frappe:develop Jul 30, 2024
16 checks passed
@blaggacao blaggacao deleted the payments/pr-5 branch July 30, 2024 12:04
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants