Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NEW (Extension) @W-16442046@ do not throw error when source is undefined #118

Closed
wants to merge 2 commits into from
Closed

NEW (Extension) @W-16442046@ do not throw error when source is undefined #118

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e86cc5a
fix: do not throw error when source is undefined
gbockus-sf Aug 16, 2024
fe4c145
Merge branch 'dev' into gbockus/fix-endsWith-error
gbockus-sf Aug 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/lib/messages.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,13 @@ export const messages = {
messageGenerator: (severity: number, message: string) => `Sev${severity}: ${message}`,
source: {
generator: (engine: string) => `${engine} via Code Analyzer`,
isSource: (source: string) => source.endsWith(' via Code Analyzer'),
isSource: (source: string) => {
if (!source) {
return false;
}

return source.endsWith(' via Code Analyzer');
},
Comment on lines +49 to +55
Copy link
Collaborator

@stephen-carter-at-sf stephen-carter-at-sf Aug 16, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lower golf score:

isSource: (source: string) => source && source.endsWith(' via Code Analyzer'),

or even better

isSource: (source: string) => source?.endsWith(' via Code Analyzer'),

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gbockus-sf - looks like you need code signing set up. I'll take care of this if that's fine with you. Apologies for the delay - this has been on my todo ever since you reported. I should have gotten to this quicker!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gbockus-sf : Here is the PR with similar fix to another function + tests. @stephen-carter-at-sf: Both your suggestions return undefined instead of false when source is falsy in my tests. This was a surprise to me. I have left the code as is for now. I'll go ahead and close this PR without merging.

extractEngine: (source: string) => source.split(' ')[0]
}
},
Expand Down
Loading