NEW (Extension) @W-16442046@ do not throw error when source is undefined #118
Conversation
jag-j
changed the title
| isSource: (source: string) => { | ||
| if (!source) { | ||
| return false; | ||
| } | ||
|
|
||
| return source.endsWith(' via Code Analyzer'); | ||
| }, |
There was a problem hiding this comment.
Lower golf score:
isSource: (source: string) => source && source.endsWith(' via Code Analyzer'),
or even better
isSource: (source: string) => source?.endsWith(' via Code Analyzer'),
There was a problem hiding this comment.
@gbockus-sf - looks like you need code signing set up. I'll take care of this if that's fine with you. Apologies for the delay - this has been on my todo ever since you reported. I should have gotten to this quicker!
There was a problem hiding this comment.
@gbockus-sf : Here is the PR with similar fix to another function + tests. @stephen-carter-at-sf: Both your suggestions return undefined instead of false when source is falsy in my tests. This was a surprise to me. I have left the code as is for now. I'll go ahead and close this PR without merging.
Kept seeing an error in VSCode randomly associated with CA extension. Figured I'd take a quick peek to see if I could figure out why.
Root cause here:
sfdx-code-analyzer-vscode/src/lib/fixer.ts
Line 27 in 4ed5252
I can't really explain why TS isn't complaining about the string | undefined mismatch with the isSource method, but this should prevent the error.
I didn't see any tests covering this area, but lemme know if I missed it.