Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove core from dependencies #592

Merged
merged 3 commits into from
Jul 30, 2024
Merged

feat: remove core from dependencies #592

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f6829c3
feat: remove core from dependencies
mingxuanzhangsfdx Jul 30, 2024
bd43a9c
chore: dir test
mingxuanzhangsfdx Jul 30, 2024
59548b6
chore: apply suggestions
mingxuanzhangsfdx Jul 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions .eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,7 @@
"sourceType": "module"
},
"plugins": ["@typescript-eslint", "jsdoc", "eslint-plugin-header"],
"extends": [
"plugin:@typescript-eslint/recommended",
"plugin:prettier/recommended"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found out that with the "plugin:prettier/recommended" there will be a conflict of linting with auto-save and prettier. Given that it will lint with prettier when push, there is no need to add this check with conflict.

],
"extends": ["plugin:@typescript-eslint/recommended"],
"rules": {
"ban-ts-ignore": "off",
"@typescript-eslint/ban-ts-ignore": "off",
Expand Down
3 changes: 1 addition & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
"/messages"
],
"dependencies": {
"@salesforce/core": "^8.1.1",
"@salesforce/kit": "^3.1.6",
"ejs": "^3.1.10",
"got": "^11.8.2",
Expand Down Expand Up @@ -85,4 +84,4 @@
"publishConfig": {
"access": "public"
}
}
}
4 changes: 2 additions & 2 deletions src/service/gitRepoUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
* See https://github.com/vercel/next.js for more information
*/

import { Global } from '@salesforce/core';
import { CreateUtil } from '../utils';
import * as crypto from 'crypto';
import * as fs from 'fs';
import got from 'got';
Expand Down Expand Up @@ -87,7 +87,7 @@ export function getStoragePathForCustomTemplates(repoUri: URL): string {
.digest('hex');

const customTemplatesPath = path.join(
Global.DIR,
CreateUtil.DIR,
'custom-templates',
folderHash
);
Expand Down
10 changes: 10 additions & 0 deletions src/utils/createUtil.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,14 @@
*/
import * as fs from 'fs';
import * as path from 'path';
import * as os from 'node:os';
import { nls } from '../i18n';

/* tslint:disable:no-unused-expression */

export class CreateUtil {
private static SFDX_STATE_FOLDER = '.sfdx';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer the logic for DIR be moved to src/service/gitRepoUtils.ts. It is only used in one place.


public static checkInputs(flagValue: string): string {
const alphaRegExp = /^\w+$/;

Expand Down Expand Up @@ -75,4 +78,11 @@ export class CreateUtil {
}
return subdirs;
}

/**
* The full system path to the preferred global state folder
*/
public static get DIR(): string {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move to src/service/gitRepoUtils.ts

return path.join(os.homedir(), CreateUtil.SFDX_STATE_FOLDER);
}
}
Loading
Loading