-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove core from dependencies #592
Conversation
@@ -6,10 +6,7 @@ | |||
"sourceType": "module" | |||
}, | |||
"plugins": ["@typescript-eslint", "jsdoc", "eslint-plugin-header"], | |||
"extends": [ | |||
"plugin:@typescript-eslint/recommended", | |||
"plugin:prettier/recommended" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found out that with the "plugin:prettier/recommended" there will be a conflict of linting with auto-save and prettier. Given that it will lint with prettier when push, there is no need to add this check with conflict.
src/utils/createUtil.ts
Outdated
import { nls } from '../i18n'; | ||
|
||
/* tslint:disable:no-unused-expression */ | ||
|
||
export class CreateUtil { | ||
private static SFDX_STATE_FOLDER = '.sfdx'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer the logic for DIR be moved to src/service/gitRepoUtils.ts
. It is only used in one place.
src/utils/createUtil.ts
Outdated
/** | ||
* The full system path to the preferred global state folder | ||
*/ | ||
public static get DIR(): string { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move to src/service/gitRepoUtils.ts
What does this PR do?
This PR removes
@salesforce/core
from dependencies, reduces the total size of the library.What issues does this PR fix or reference?
@W-16301500@