Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove LiteralTypeForLiteral by creating IsInstance function #5909

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Remove literalTypeForLiteral

af0ea73
Select commit
Loading
Failed to load commit list.
Open

Remove LiteralTypeForLiteral by creating IsInstance function #5909

Remove literalTypeForLiteral
af0ea73
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 24, 2024 in 0s

36.75% (+0.26%) compared to 6c4f8db

View this Pull Request on Codecov

36.75% (+0.26%) compared to 6c4f8db

Details

Codecov Report

Attention: Patch coverage is 39.78495% with 112 lines in your changes missing coverage. Please review.

Project coverage is 36.75%. Comparing base (6c4f8db) to head (af0ea73).
Report is 20 commits behind head on master.

Files with missing lines Patch % Lines
flytepropeller/pkg/compiler/validators/utils.go 32.05% 98 Missing and 8 partials ⚠️
...tepropeller/pkg/compiler/errors/compiler_errors.go 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5909      +/-   ##
==========================================
+ Coverage   36.49%   36.75%   +0.26%     
==========================================
  Files        1296     1309      +13     
  Lines      109571   130941   +21370     
==========================================
+ Hits        39988    48130    +8142     
- Misses      65426    78624   +13198     
- Partials     4157     4187      +30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.