Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove LiteralTypeForLiteral by creating IsInstance function #5909

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Remove literalTypeForLiteral

af0ea73
Select commit
Loading
Failed to load commit list.
Open

Remove LiteralTypeForLiteral by creating IsInstance function #5909

Remove literalTypeForLiteral
af0ea73
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Oct 24, 2024 in 0s

39.78% of diff hit (target 36.49%)

View this Pull Request on Codecov

39.78% of diff hit (target 36.49%)

Annotations

Check warning on line 221 in flytepropeller/pkg/compiler/errors/compiler_errors.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flytepropeller/pkg/compiler/errors/compiler_errors.go#L216-L221 

Added lines #L216 - L221 were not covered by tests

Check warning on line 185 in flytepropeller/pkg/compiler/validators/utils.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flytepropeller/pkg/compiler/validators/utils.go#L182-L185 

Added lines #L182 - L185 were not covered by tests

Check warning on line 188 in flytepropeller/pkg/compiler/validators/utils.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flytepropeller/pkg/compiler/validators/utils.go#L187-L188 

Added lines #L187 - L188 were not covered by tests

Check warning on line 191 in flytepropeller/pkg/compiler/validators/utils.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flytepropeller/pkg/compiler/validators/utils.go#L190-L191 

Added lines #L190 - L191 were not covered by tests

Check warning on line 207 in flytepropeller/pkg/compiler/validators/utils.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flytepropeller/pkg/compiler/validators/utils.go#L206-L207 

Added lines #L206 - L207 were not covered by tests

Check warning on line 212 in flytepropeller/pkg/compiler/validators/utils.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flytepropeller/pkg/compiler/validators/utils.go#L210-L212 

Added lines #L210 - L212 were not covered by tests

Check warning on line 219 in flytepropeller/pkg/compiler/validators/utils.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flytepropeller/pkg/compiler/validators/utils.go#L219 

Added line #L219 was not covered by tests

Check warning on line 231 in flytepropeller/pkg/compiler/validators/utils.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flytepropeller/pkg/compiler/validators/utils.go#L230-L231 

Added lines #L230 - L231 were not covered by tests

Check warning on line 241 in flytepropeller/pkg/compiler/validators/utils.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flytepropeller/pkg/compiler/validators/utils.go#L240-L241 

Added lines #L240 - L241 were not covered by tests

Check warning on line 244 in flytepropeller/pkg/compiler/validators/utils.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flytepropeller/pkg/compiler/validators/utils.go#L244 

Added line #L244 was not covered by tests

Check warning on line 260 in flytepropeller/pkg/compiler/validators/utils.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flytepropeller/pkg/compiler/validators/utils.go#L254-L260 

Added lines #L254 - L260 were not covered by tests

Check warning on line 263 in flytepropeller/pkg/compiler/validators/utils.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flytepropeller/pkg/compiler/validators/utils.go#L263 

Added line #L263 was not covered by tests

Check warning on line 274 in flytepropeller/pkg/compiler/validators/utils.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flytepropeller/pkg/compiler/validators/utils.go#L270-L274 

Added lines #L270 - L274 were not covered by tests

Check warning on line 279 in flytepropeller/pkg/compiler/validators/utils.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flytepropeller/pkg/compiler/validators/utils.go#L276-L279 

Added lines #L276 - L279 were not covered by tests

Check warning on line 284 in flytepropeller/pkg/compiler/validators/utils.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flytepropeller/pkg/compiler/validators/utils.go#L282-L284 

Added lines #L282 - L284 were not covered by tests

Check warning on line 286 in flytepropeller/pkg/compiler/validators/utils.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flytepropeller/pkg/compiler/validators/utils.go#L286 

Added line #L286 was not covered by tests

Check warning on line 304 in flytepropeller/pkg/compiler/validators/utils.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flytepropeller/pkg/compiler/validators/utils.go#L293-L304 

Added lines #L293 - L304 were not covered by tests

Check warning on line 308 in flytepropeller/pkg/compiler/validators/utils.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flytepropeller/pkg/compiler/validators/utils.go#L306-L308 

Added lines #L306 - L308 were not covered by tests

Check warning on line 318 in flytepropeller/pkg/compiler/validators/utils.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flytepropeller/pkg/compiler/validators/utils.go#L316-L318 

Added lines #L316 - L318 were not covered by tests

Check warning on line 320 in flytepropeller/pkg/compiler/validators/utils.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flytepropeller/pkg/compiler/validators/utils.go#L320 

Added line #L320 was not covered by tests

Check warning on line 329 in flytepropeller/pkg/compiler/validators/utils.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flytepropeller/pkg/compiler/validators/utils.go#L322-L329 

Added lines #L322 - L329 were not covered by tests

Check warning on line 334 in flytepropeller/pkg/compiler/validators/utils.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flytepropeller/pkg/compiler/validators/utils.go#L331-L334 

Added lines #L331 - L334 were not covered by tests

Check warning on line 338 in flytepropeller/pkg/compiler/validators/utils.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flytepropeller/pkg/compiler/validators/utils.go#L336-L338 

Added lines #L336 - L338 were not covered by tests

Check warning on line 367 in flytepropeller/pkg/compiler/validators/utils.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flytepropeller/pkg/compiler/validators/utils.go#L361-L367 

Added lines #L361 - L367 were not covered by tests

Check warning on line 371 in flytepropeller/pkg/compiler/validators/utils.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flytepropeller/pkg/compiler/validators/utils.go#L371 

Added line #L371 was not covered by tests
View more details on Codecov