-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sfppackage): fix handling of URL-encoded spaces in repository URLs #138
fix(sfppackage): fix handling of URL-encoded spaces in repository URLs #138
Conversation
750699c
to
25dd3a1
Compare
I need a little help figuring out how to make Codacy happy. I don't believe that I've introduced any new issues, and I'm not sure what needs to be done to address its concerns. |
3e88504
to
422df8b
Compare
…seable This adds a skipped test that should be enabled after flxbl-io#137
422df8b
to
ed6e67f
Compare
It looks like this may be a limitation of how Codacy is configured/works. I reported a blocking bug at #140 |
I've expanded the patch to include the fix for the issue. |
… URL This updates git-parse-url to version 16.0.0.
ec25e27
to
7c9412e
Compare
@richard-giraud yeah its more of a limitation on codacy, I will have a look, Thanks for the PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okie 👍
This fixes #137
If the repository URL includes an URL-encoded space (i.e.,
%20
),sfp install
will fail to parse it. The user is presented with a rather unhelpful message:This PR makes 2 changes:
A test was added to support the problematic case.
Checklist
All items have to be completed before a PR is merged