Skip to content

Commit

Permalink
fix(sfppackage): fix handling of URL-encoded whitespace in repository…
Browse files Browse the repository at this point in the history
… URL

This updates git-parse-url to version 16.0.0.
  • Loading branch information
richard-giraud committed Nov 19, 2024
1 parent ed6e67f commit 7c9412e
Show file tree
Hide file tree
Showing 3 changed files with 21 additions and 15 deletions.
31 changes: 19 additions & 12 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
"dotenv": "16.3.1",
"fast-xml-parser": "4.5.0",
"fs-extra": "^11.1.1",
"git-url-parse": "14.0.0",
"git-url-parse": "^16.0.0",
"glob": "^10.3.3",
"handlebars": "^4.7.7",
"hot-shots": "^8.5.0",
Expand Down
3 changes: 1 addition & 2 deletions tests/core/package/SfpPackageInquirer.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,7 @@ describe('validateArtifactsSourceRepository', () => {
sfpPackageInquirer.validateArtifactsSourceRepository();
});

// TODO: re-enable once https://github.com/flxbl-io/sfp/issues/137 is fixed
it.skip.failing('should accept a good repository SSH URL with a URL-encoded space', async () => {
it('should accept a good repository SSH URL with a URL-encoded space', async () => {
const repositoryUrl = '[email protected]:flxbl-io/sfp%20test.git';

let sfpPackage: SfpPackage = new SfpPackage();
Expand Down

0 comments on commit 7c9412e

Please sign in to comment.