[proposal] Rename rust-to-python exports to be cleaner, normalize exception names #2663
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think
PySyncClient
et al are a bit weird in python land, so I propose normalizing on:Client
/Table
/etc for synchronousClientAsync
/TableAsync
/etc for asynchronousThis is pretty trivial to do it seems, so little downside
Separately, I propose using the following names:
PerspectiveError
: Error in the C++/Rust perspective enginePerspectivePythonError
: error in just the python slice of the codebaseIdeally these should inherit from a common base class (maybe
PerspectivePythonError
can inherit fromPerspectiveError
, but it would be nice to very clearly disambiguate engine errors from python land errors (e.g. web server or other utilities' errors)