-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs and examples update for new API #2659
base: master
Are you sure you want to change the base?
Conversation
57c0901
to
ad56647
Compare
Signed-off-by: Andrew Stein <[email protected]>
Signed-off-by: Andrew Stein <[email protected]> # Conflicts: # examples/python-tornado/server.py # rust/perspective-python/Cargo.toml # rust/perspective-python/perspective/__init__.py
Signed-off-by: Andrew Stein <[email protected]>
Signed-off-by: Andrew Stein <[email protected]>
36af4df
to
bf7aa8e
Compare
... await handler.run() | ||
... app.add_api_websocket_route('/websocket', endpoint) | ||
""" | ||
|
||
def __init__(self, **kwargs): | ||
self._server = kwargs.pop("perspective_server") | ||
self._websocket = kwargs.pop("websocket") | ||
super().__init__(**kwargs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not needed, also don't need to use kwargs (no inheritance anymore)
... await handler.run() | ||
>>> app = web.Application() | ||
>>> app.router.add_get("/websocket", websocket_handler) | ||
""" | ||
|
||
def __init__(self, **kwargs): | ||
self.server = kwargs.pop("perspective_server") | ||
self._request = kwargs.pop("request") | ||
super().__init__(**kwargs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not needed, also don't need to use kwargs (no inheritance anymore)
server = Server() | ||
client = Client.from_server( | ||
server, | ||
loop_callback=lambda fn, *args: TestAsync.loop.add_callback(fn, *args), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all these blocks don't need lambdas anymore
# ┗━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┛ | ||
|
||
|
||
class PerspectiveError(Exception): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think #2663 is better overall, allows us to differentiate engine errors from non-engine errors while still catching both
bf7aa8e
to
5a0ea2e
Compare
df73639
to
7f7a539
Compare
Signed-off-by: Andrew Stein <[email protected]>
8d399f4
to
60a2a02
Compare
Signed-off-by: Andrew Stein <[email protected]>
60a2a02
to
e8741cc
Compare
No description provided.