Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have softmax handle any dim via permutation #832

Closed
wants to merge 1 commit into from
Closed

Have softmax handle any dim via permutation #832

wants to merge 1 commit into from

Commits on Jul 17, 2023

  1. Have softmax handle any dim via permutation (facebookincubator#832) 

    Summary:
Pull Request resolved: facebookincubator#832

Since the backend doesn't yet support reduction over non-last-dimensions, I'm
having the frontend add two permute ops to move the desired dimension to the
end of the shape.

I considered modifying the softmax template code instead of creating new op
instances, but the `permute()` op has a bunch of logic for dispatching to more
specialized versions of itself, and it seems the easiest way to take advantage
of that is by creating instances of the permute op.

Reviewed By: aakhundov

Differential Revision: D47506000

fbshipit-source-id: b3522fdbb0154d9caa5a4865653aec1816de6bc9
    @int3 @facebook-github-bot
    int3 authored and facebook-github-bot committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    11f320d View commit details
    Browse the repository at this point in the history