Have softmax handle any dim via permutation #832
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D47506000 |
Summary: Pull Request resolved: facebookincubator#832 Since the backend doesn't yet support reduction over non-last-dimensions, I'm having the frontend add two permute ops to move the desired dimension to the end of the shape. I considered modifying the softmax template code instead of creating new op instances, but the `permute()` op has a bunch of logic for dispatching to more specialized versions of itself, and it seems the easiest way to take advantage of that is by creating instances of the permute op. Reviewed By: aakhundov Differential Revision: D47506000 fbshipit-source-id: b3522fdbb0154d9caa5a4865653aec1816de6bc9
|
This pull request was exported from Phabricator. Differential Revision: D47506000 |
|
This pull request has been merged in 737067f. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Since the backend doesn't yet support reduction over non-last-dimensions, I'm
having the frontend add two permute ops to move the desired dimension to the
end of the shape.
I considered modifying the softmax template code instead of creating new op
instances, but the
permute()op has a bunch of logic for dispatching to morespecialized versions of itself, and it seems the easiest way to take advantage
of that is by creating instances of the permute op.
Differential Revision: D47506000