Skip to content

2.2 Release test Checklist

Jump to bottom
Ben Clark edited this page Jan 4, 2024 · 51 revisions

Key:

  • 🐛 is for issues that we aren't planning on shipping and are known to not be working. Each of these should have an issue link associated.
  • ⚠️ is for a known bug that we still need to fix prior to getting this release out the door. Should also link out to issues created.
  • 🚢 is for an issue whose bug as been squashed. Ship it!

Release tasks

  • Bump version to whatever is appropriate
  • Update CHANGELOG to contain latest on bugfixes, improvements, etc.
  • Update Splash screen do cover latest happenings
  • Update discussion at: https://github.com/facebook/Rapid/discussions/993 with the latest from the internal docs
  • Check in the latest artifacts to dist/

Test Suite passes

  • Fix any/all issues with 'npm test' that have crept in since our last release.

Bundle size

Inspect and compare bundle sizes and ensure:

  • No imports are double-included
  • No bundled dependencies are unexpectedly large (Note: We did include mapLibre in this bundle, so the bundle size increased appreciably by 1.3 MB)

Release-specific testing for new features

  • Ambiguous Crossing Way validation

    • Testing without Power User Mode
      • Ambiguous (marked / unmarked) fixable and generates ⚠️
      • Conflicting (both marked, but marked differently) and generates ❌
      • Candidates are flagged as ⚠️
    • Testing with Power User Mode
      • Test auto-fix buttons for all three of the above, ensure that the way tag overwrites the node

  • Ensure that the new presets are available- 7 crossing ways, 2 new tree types, and the curbs

  • Cycle Highway Tags

    • Test on regular highways
    • Test on bare, untagged way
    • Test on way that has tags but is not highway
    • Test on crossing way with no marking tags
    • Test on crossing way with markings
    • Test on highway with highway=footway but without footway=crossing
    • Test on highway without highway=footway but with footway=crossing
    • use right-click and see if the operation is supported for points, areas

  • test 3d map reload, ensure 3dmap url param is honored

    • what if 3dmap is false?

  • Streetview Changes

    • Test Kartaview imagery
    • Test Streetside Imagery
    • Test Mapillary Imagery
      • Ensure the panoramic imagery viewfield is show and updates as the user pans
      • Ensure the imagery viewfield stretches/reforms as the user zooms in/out
    • Ensure that the keyboard arrow keys navigate from point to point (all layers?)
    • Ensure that the panoramic image viewpoint is sticky from selection to selection

  • Connect a crosswalk to an existing way, there should be no lint generated for upgrading the tag

  • Specific testing for #1103

  • Click an item to get the id param filled, then zoom far away and reload, rapid should zoom in on the item in the id field that you clicked on

  • Do a BUNCH of changes to the map, reload the browser, and click 'Restore my changes' as soon as possible, the browser should not stack trace/crash.

  • Make changes with one kind of imagery, click 'save', should see one kind of imagery in the changeset tags.

  • Make changes with multiple kinds of imagery, click 'save', should see multiple kinds of imagery in the changeset tags.

  • Make changes with the validation window open. Intentionally try to get validations to fire and go away:

    • With just the 'my' changes
    • With all things everywhere
    • With just what's on screen

  • Make some edits, save, and on reload the same changeset comment should be propagated into the comment text bar and the message field should receive focus automatically- Other elements in the changeset UI should function properly.

  • Click on a third-party link somewhere in the UI- it should work properly and not be a relative link from rapieditor.org.

  • Ensure the MS Building license is correct.

  • Verify that 'way over waterway' validations are firing.

  • Validate that the colors.json does in fact change some of the colors shown in the map.

#Keyboard Shortcuts

Browsing:

Navigation

  • Arrow keys pan the map ↓, ↑, ←, →
  • ⌥ + Arrow keys pan the map more
  • + and - keys zoom in and out
  • ⌥ - and ⌥ + zoom the map more
  • ✅ L zooms to location (Did we get rid of this?) Fixed!

Geocoding

  • Type a placename into the search bar, hit 'Search Entire World', see a list of items
  • 🐛 Click on a member of that list to automatically zoom/pan to the entity in question

Display Options

  • B Toggles the imagery pane
  • ⌘+B switches to last background
  • , switches to previous background in list #1233 Fixed!
  • . switches to next background in list #1233 Fixed!
  • F toggles the map data pane
  • I toggles the validation issues pane
  • P Toggles the user preferences pane
  • ✅ ⌃Ctrl + ⌘Cmd + F or F11 switch to full screen mode : #1026
  • ✅ ` key or ² toggles the sidebar : #1029 Fixed!
  • W toggles wireframe mode
  • ⌥ W toggles OSM data on/off
  • / toggles the minimap on/off
  • ⌘Cmd+/ toggles the 3d map on/off #1234 Fixed!
  • 3D Map allows right-click to adjust viewing angle and spin around the center point #1234 Fixed!
  • mousing off the 3D map causes it to snap back to true north orientation #1234 Fixed!
  • g highlights unsaved edits #509
  • Shift + R Toggles rapid features on/off

Help

  • H toggles help
  • ? toggles keyboard shortcuts

Selecting Features

  • l-click, tap, or space selects a feature
  • shift + l-click selects multiple
  • shift+ l-click + drag draws a lasso selection around features
  • ⌘ F finds features matching search text #1007

With features selected

  • Right-click or long press or menu button (space bar) toggles the edit menu
  • Z zooms to the selected features

With node selected

  • [ or ↖ PgUp jump to previous node
  • ] or ↘ PgDown jump to next node
  • { or ⇞ Home jump to first node
  • } or ⇟ End jump to last node
  • ⌘ ↑ selects parent way #1237
  • \ or Pause switches parent way #1237

With Way Selected

  • ⌘ ↓ selects child nodes #1237

Editing

Drawing

  • 1 Add Point mode
  • 2 Add Line mode
  • 3 Add Area mode
  • N Add Note mode (when enabled)
  • l-click, tap, or Spacebar should add a point or note while in this mode
  • ⌥ Option holding should disable point snapping
  • ↵Return or ⎋Esc should finish drawing a line or area

Commands

  • ⌘ Cmd + C copies selected feature
  • ⌘ Cmd + V pastes selected feature
  • ⌘ Cmd + Z Undoes last edit
  • ⌘ Cmd + ⇧ Shift + Z Redoes last edit
  • ⌘ Cmd + S saves changes to OSM

RapiD AI-Assist

  • A adds the selected rapid feature
  • D ignores the selected feature

Operations

  • A continues a line at the selected endpoint
  • C combines (merges) selected features
  • D disconnects the selected features
  • E extracts a point from a feature
  • X splits features at the selected points
  • v reverses the selected features
  • m moves the selected features
  • ⇧Shift + ↓, ↑, ←, → nudge the feature by a small amount #525
  • ⌥Option ⇧Shift + ↓, ↑, ←, → nudge the feature by a lot #525
  • ⇧Shift + + or - scales the feature #912
  • ⌥Option⇧Shift + + or - scales the feature #912
  • R rotates the selected features
  • Q squares the corners of a line or area
  • S straightens the line or group of points
  • O circularizes a closed line or area
  • T flips features across the long axis
  • Y flips features across the shorter axis
  • ⌘Cmd + ⌫Delete deletes the selected feature
  • ⇧Shift + C cycles the road tag preset for a way

Tools

Information

  • ⌘Cmd + I Toggles all information panels
  • ⌘Cmd + ⇧Shift + B Toggles Background panel
  • ⌘Cmd + ⇧Shift + H Toggles History panel
  • ⌘Cmd + ⇧Shift + L Toggles Location panel
  • ⌘Cmd + ⇧Shift + M Toggles Measurement panel

Drawing

Points

  • Clicking an empty map area creates a new node.
  • Clicking on an existing vertex creates a new node.
  • After node creation, the 'tag this feature' dialog appears in the sidebar, prompting the user to classify the feature.
  • Directional points show their facing with viewfield cones
  • Undo/redo works as expected

Ways

All new nodes

  • Creating a new way works by just mouse clicking from point to point, ending by clicking the same point twice.

  • History undo/redo for previous looks good and does not have 'extra' states in it.

  • Same, but with clicking the FIRST point to close the way.

  • History undo/redo for previous looks good and does not have 'extra' states in it.

  • Hitting ESC can end the draw mode.

  • History undo/redo for previous looks good and does not have 'extra' states in it.

  • ❌ History undo/redo during the draw operation looks good and does not have 'extra' states in it. 🐛 : Extra undo state in way and area drawing modes #1235

Combination of new / existing vertices / points

  • Creating a new way works by just mouse clicking from point to point, ending by clicking the same point twice.

  • History undo/redo for previous looks good and does not have 'extra' states in it.

  • Same, but with clicking the FIRST point to close the way.

  • History undo/redo for previous looks good and does not have 'extra' states in it.

  • Hitting ESC can end the draw mode.

  • History undo/redo for previous looks good and does not have 'extra' states in it.

  • ❌ History undo/redo during the draw operation looks good and does not have 'extra' states in it. 🐛 : Extra undo state in way and area drawing modes #1235

New way from ONLY existing vertices / points

  • Creating a new way works by just mouse clicking from point to point, ending by clicking the same point twice.

  • History undo/redo for previous looks good and does not have 'extra' states in it.

  • Same, but with clicking the FIRST point to close the way.

  • History undo/redo for previous looks good and does not have 'extra' states in it.

  • Hitting ESC can end the draw mode.

  • History undo/redo for previous looks good and does not have 'extra' states in it.

  • ❌ History undo/redo during the draw operation looks good and does not have 'extra' states in it. 🐛 : Extra undo state in way and area drawing modes #1235

Areas

All new nodes

  • Creating a new area works by just mouse clicking from point to point, ending by clicking the first point twice.

  • History undo/redo for previous looks good and does not have 'extra' states in it.

  • Hitting ESC can end the draw mode, auto-closing the area.

  • History undo/redo for previous looks good and does not have 'extra' states in it.

  • ❌ History undo/redo during the draw operation looks good and does not have 'extra' states in it. 🐛 : Extra undo state in way and area drawing modes #1235

Combination of new / existing vertices / points

  • Creating a new area works by just mouse clicking from point to point, ending by clicking the first point twice.

  • History undo/redo for previous looks good and does not have 'extra' states in it.

  • ❌ History undo/redo during the draw operation looks good and does not have 'extra' states in it. 🐛 : Extra undo state in way and area drawing modes #1235

  • Same as previous creation test, but instead of clicking on the first node, hit ESC to end the draw mode.

  • History undo/redo for previous looks good and does not have 'extra' states in it.

  • ❌ History undo/redo during the draw operation looks good and does not have 'extra' states in it. 🐛 : Extra undo state in way and area drawing modes #1235

New area from ONLY existing vertices / points

  • Creating a new area works by just mouse clicking from point to point, ending by clicking the same point twice.

  • History undo/redo for previous looks good and does not have 'extra' states in it.

  • Same, but with clicking the FIRST point to close the area.

  • History undo/redo for previous looks good and does not have 'extra' states in it.

  • Hitting ESC can end the draw mode.

  • History undo/redo after finishing the draw operation looks good and does not have 'extra' states in it.

  • ❌ History undo/redo during the draw operation looks good and does not have 'extra' states in it. 🐛 : Extra undo state in way and area drawing modes #1235

Walkthrough

Get through all steps without help

  • Welcome
  • Navigation
  • Points
  • Areas
  • Ways #1226 Fixed!
  • Buildings
  • Rapid #1227 Fixed
  • Finish
Clone this wiki locally