Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/embedded/11 #43

Open
wants to merge 4 commits into
base: embedded
Choose a base branch
from
Open

Feature/embedded/11 #43

wants to merge 4 commits into from

Conversation

gehadelkoumy
Copy link
Collaborator

In this pull request we:

  • Test the 3 motors using cytrons 1 channel.
  • Get encoder readings.

mennamamdouh
mennamamdouh reviewed Apr 13, 2023
View reviewed changes
Copy link
Collaborator

@mennamamdouh mennamamdouh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Keep going

@eslamdyab21
Copy link
Owner

@gehadelkoumy Good job, plz add some pictures of the hardware components and screenshots of the encoder readings as well in the documentation for better illustration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mennamamdouh mennamamdouh mennamamdouh left review comments

@Islamoo7 Islamoo7 Islamoo7 approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees

@Islamoo7 Islamoo7

@mennamamdouh mennamamdouh

@eslamdyab21 eslamdyab21

@Ahmmed2 Ahmmed2

@aya250 aya250

@JessicaEmad JessicaEmad

Labels
embedded
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@gehadelkoumy @eslamdyab21 @Islamoo7 @mennamamdouh @Ahmmed2 @aya250 @JessicaEmad