Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish additional information #27

Merged
merged 4 commits into from
Dec 4, 2020
Merged

Publish additional information #27

merged 4 commits into from
Dec 4, 2020

Conversation

costashatz
Copy link
Collaborator

@costashatz costashatz commented Mar 9, 2020

Publish additional information:

  • External torques
  • Commanded torques
  • Commanded positions

This is WIP...

@costashatz costashatz self-assigned this Mar 9, 2020
@costashatz costashatz added the enhancement New feature or request label Mar 9, 2020
@costashatz
Copy link
Collaborator Author

@JimmyDaSilva sorry for taking too long to merge this. I managed to perform some tests and it is working like a charm. I will fix the conflicts and merge. Thanks for this again!

@matthias-mayr
Copy link
Contributor

I merged this into master on my fork and it works for me. Is there something else that should be checked before merging it?

@costashatz
Copy link
Collaborator Author

Is there something else that should be checked before merging it?

Nothing really. Have you experienced any lag or weird issue?

I haven't found time to test it thoroughly. If you tell it is OK, I will merge now..

@matthias-mayr
Copy link
Contributor

I double-checked published values with the ones on the SmartPad.
I also plotted the external torque and pushed the robot. The plot looked reasonable.

Maybe @JimmyDaSilva has some more experience with the other information.

@JimmyDaSilva
Copy link
Contributor

Hi guys. Actually, I quit using iiwa_ros because I had too many issues with hard real-time control, as mentioned here #36.
I have used the "Additional outputs" back then and the values were great.

I remember investigating if my latency issues were coming from this PR.
My issues appeared using both the master branch and this PR, and I think with the same consistency.
This is no thorough proof, but I think this PR is ok. Especially thanks to the use of the realtime_tools::Publisher

@JimmyDaSilva
Copy link
Contributor

JimmyDaSilva commented Dec 4, 2020

Although, it seems the realtime_tools::Publisher cannot be used with control frequencies higher than 750Hz because of ros-controls/realtime_tools#23

@costashatz
Copy link
Collaborator Author

@JimmyDaSilva @matthias-mayr thank you for your comments.. I will merge asap!

@costashatz costashatz merged commit 920f5f4 into master Dec 4, 2020
@costashatz costashatz deleted the external_torque branch December 4, 2020 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants