Skip to content
This repository has been archived by the owner on Nov 29, 2023. It is now read-only.

Fix: ensure geopicker is loaded for non-nested setgeopoint actions #904

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Fix: ensure geopicker is loaded for non-nested setgeopoint actions #904

wants to merge 2 commits into from

Commits on Jun 7, 2022

  1. Fix: setgeopoint actions correctly identify their affected nodeset 

    Current behavior:

1. Actions defined in the model, or in the body *adjacent* its input, populate the model correctly.
2. Actions nested within their input, with an explicit `ref` attribute, fail to update the view. This is because there is a hidden HTML input representing the action (distinct from the input representing the model value), which the current behavior selects.
3. Actions nested within their input, *without* an explicit `ref` attribute, replace the entire descendant tree of the model with the geopoint value. The cause is identical to the explicit-ref case, but the erroneously selected input has no `name` attribute. This causes the model update, in `Nodeset.setVal`, to evaluate against a nodeset resolving to the root `data` node.
    @eyelidlessness
    eyelidlessness committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    34af7e6 View commit details
    Browse the repository at this point in the history

  2. Fix: ensure geopicker is loaded for non-nested setgeopoint actions

    @eyelidlessness
    eyelidlessness committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    ddd5e0b View commit details
    Browse the repository at this point in the history