This repository has been archived by the owner on Nov 29, 2023. It is now read-only.
Fix: ensure geopicker is loaded for non-nested setgeopoint actions #904
+178
−95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current behavior: 1. Actions defined in the model, or in the body *adjacent* its input, populate the model correctly. 2. Actions nested within their input, with an explicit `ref` attribute, fail to update the view. This is because there is a hidden HTML input representing the action (distinct from the input representing the model value), which the current behavior selects. 3. Actions nested within their input, *without* an explicit `ref` attribute, replace the entire descendant tree of the model with the geopoint value. The cause is identical to the explicit-ref case, but the erroneously selected input has no `name` attribute. This causes the model update, in `Nodeset.setVal`, to evaluate against a nodeset resolving to the root `data` node.
eyelidlessness
force-pushed
the
fix/geopicker-selector
branch
from
d9ca4a6
to
e537627
Compare
eyelidlessness
force-pushed
the
fix/geopicker-selector
branch
from
e537627
to
ddd5e0b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses discrepancies in the DOM representation similar to those found in #903. I'm not totally confident this selector is safe, but it handles all of the cases I was able to identify, without reintroducing the duplicate-widget bug fixed in #896.
Edit: branched from #903 because the form under test depends on that fix.