ignore dataLayer source

elbwalker · Dec 18, 2024 · 5e9a7b7 · 5e9a7b7
1 parent 9af0a6a
commit 5e9a7b7
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 15 deletions.
diff --git a/packages/sources/walkerjs/src/__tests__/destination.test.ts b/packages/sources/walkerjs/src/__tests__/destination.test.ts
@@ -713,19 +713,19 @@ describe('Destination', () => {
     expect(mockPushLatest).toHaveBeenCalledTimes(0);
   });
 
-  test('loop prevention', () => {
-    elb('walker run');
-    destination.type = 'foo';
-    elb('walker destination', destination);
-
-    elb({ event: 'e a' });
-    elb({ event: 'e a', source: { type: 'another one' } });
-    expect(mockPush).toHaveBeenCalledTimes(2);
+  test('dataLayer source', () => {
+    walkerjs = Walkerjs({
+      dataLayer: true,
+      run: true,
+      session: false,
+    });
+    jest.resetAllMocks();
 
-    jest.clearAllMocks();
-    elb({ event: 'e a', source: { type: 'foo' } });
+    elb({ ...event, source: { type: 'dataLayer' } });
+    expect(mockDataLayer).toHaveBeenCalledTimes(0);
 
-    expect(mockPush).toHaveBeenCalledTimes(0);
+    elb({ ...event, source: { type: 'web' } });
+    expect(mockDataLayer).toHaveBeenCalledTimes(1);
   });
 
   test('id namings', () => {

diff --git a/packages/sources/walkerjs/src/lib/destination.ts b/packages/sources/walkerjs/src/lib/destination.ts
@@ -51,6 +51,9 @@ export function dataLayerDestination() {
   };
   const destination: DestinationWeb.DestinationInit = {
     push: (event, config, mapping, options = {}) => {
+      // Do not process events from dataLayer source
+      if (event.source?.type === 'dataLayer') return;
+
       const data = options.data || event;
       dataLayerPush(data);
     },
@@ -128,10 +131,6 @@ export function destinationPush(
     }
   }
 
-  // Prevent recursive loops between sources and destinations
-  if (isDefined(destination.type) && destination.type === event.source.type)
-    return false;
-
   const options = { data, instance };
 
   return !!tryCatch(() => {