ignore dataLayer source

elbwalker · Dec 18, 2024 · 9af0a6a · 9af0a6a
1 parent b1ce9a2
commit 9af0a6a
Show file tree

Hide file tree

Showing 6 changed files with 49 additions and 2 deletions.
diff --git a/packages/destinations/web/google-ads/src/index.test.ts b/packages/destinations/web/google-ads/src/index.test.ts
@@ -22,8 +22,7 @@ describe('destination Google Ads', () => {
 
     w.gtag = mockFn;
 
-    Walkerjs({ pageview: false, session: false });
-    elb('walker run');
+    Walkerjs({ pageview: false, run: true, session: false });
   });
 
   afterEach(() => {});
@@ -107,6 +106,21 @@ describe('destination Google Ads', () => {
     });
   });
 
+  test('dataLayer source', () => {
+    elb('walker destination', destination);
+    destination.config.mapping = {
+      entity: { action: { custom: { label } } },
+    };
+    elb(event);
+    jest.resetAllMocks();
+
+    elb({ event, source: { type: 'dataLayer' } });
+    expect(mockFn).toHaveBeenCalledTimes(0);
+
+    elb({ event, source: { type: 'web' } });
+    expect(mockFn).toHaveBeenCalledTimes(1);
+  });
+
   test('push with value', () => {
     elb('walker destination', destination);
     destination.config.mapping = {

diff --git a/packages/destinations/web/google-ads/src/index.ts b/packages/destinations/web/google-ads/src/index.ts
@@ -39,6 +39,9 @@ export const destinationGoogleAds: Destination = {
   },
 
   push(event, config, mapping = {}): void {
+    // Do not process events from dataLayer source
+    if (event.source?.type === 'dataLayer') return;
+
     const { custom = {}, fn } = config;
     const customMapping = mapping.custom;
 

diff --git a/packages/destinations/web/google-ga4/src/index.test.ts b/packages/destinations/web/google-ga4/src/index.test.ts
@@ -125,6 +125,18 @@ describe('Destination Google GA4', () => {
     });
   });
 
+  test('dataLayer source', () => {
+    elb('walker destination', destination);
+    elb(event);
+    jest.resetAllMocks();
+
+    elb(getEvent('entity action', { source: { type: 'dataLayer' } }));
+    expect(mockFn).toHaveBeenCalledTimes(0);
+
+    elb(getEvent('entity action', { source: { type: 'web' } }));
+    expect(mockFn).toHaveBeenCalledTimes(1);
+  });
+
   test('settings', () => {
     elb('walker destination', destination, {
       custom: {

diff --git a/packages/destinations/web/google-ga4/src/index.ts b/packages/destinations/web/google-ga4/src/index.ts
@@ -52,6 +52,9 @@ export const destinationGoogleGA4: Destination = {
   },
 
   push(event, config, mapping = {}, options = {}) {
+    // Do not process events from dataLayer source
+    if (event.source?.type === 'dataLayer') return;
+
     const { custom, fn } = config;
     const customEvent = mapping.custom || {};
     if (!custom) return;

diff --git a/packages/destinations/web/google-gtm/src/index.test.ts b/packages/destinations/web/google-gtm/src/index.test.ts
@@ -81,6 +81,18 @@ describe('destination google-tag-manager', () => {
     expect(mockDataLayer).toHaveBeenLastCalledWith(event);
   });
 
+  test('dataLayer source', () => {
+    elb('walker destination', destination);
+    elb(event);
+    jest.resetAllMocks();
+
+    elb({ ...event, source: { type: 'dataLayer' } });
+    expect(mockDataLayer).toHaveBeenCalledTimes(0);
+
+    elb({ ...event, source: { type: 'web' } });
+    expect(mockDataLayer).toHaveBeenCalledTimes(1);
+  });
+
   test('push mapping data', () => {
     elb('walker destination', destination, {
       mapping: {

diff --git a/packages/destinations/web/google-gtm/src/index.ts b/packages/destinations/web/google-gtm/src/index.ts
@@ -31,6 +31,9 @@ export const destinationGoogleGTM: Destination = {
   },
 
   push(event, config, mapping, options = {}) {
+    // Do not process events from dataLayer source
+    if (event.source?.type === 'dataLayer') return;
+
     const func = config.fn || (window.dataLayer as unknown[]).push;
     func(options.data ?? event);
   },