Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: fix -skip_gate_cloning applied incorrectly to hold fixing instead of setup fixing #596

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

bugfix: fix -skip_gate_cloning applied incorrectly to hold fixing instead of setup fixing #596

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions Changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,20 @@
## Documentation
-->

# 2.2.6

## Steps

* `OpenROAD.ResizerTimingPostGRT`

* Fixed `GRT_RESIZER_GATE_CLONING` incorrectly applied to hold fixing instead
of setup fixing.

* `OpenROAD.ResizerTimingPostCTS`

* Fixed `PL_RESIZER_GATE_CLONING` incorrectly applied to hold fixing instead
of setup fixing.

# 2.2.5

## Steps
Expand Down
15 changes: 9 additions & 6 deletions openlane/scripts/openroad/rsz_timing_postcts.tcl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,15 @@ source $::env(SCRIPTS_DIR)/openroad/common/set_rc.tcl
estimate_parasitics -placement

# Resize
repair_timing -verbose -setup \
-setup_margin $::env(PL_RESIZER_SETUP_SLACK_MARGIN) \
-max_buffer_percent $::env(PL_RESIZER_SETUP_MAX_BUFFER_PCT)
set arg_list [list]
lappend arg_list -verbose
lappend arg_list -setup
lappend arg_list -setup_margin $::env(PL_RESIZER_SETUP_SLACK_MARGIN)
lappend arg_list -max_buffer_percent $::env(PL_RESIZER_SETUP_MAX_BUFFER_PCT)
if { $::env(PL_RESIZER_GATE_CLONING) != 1 } {
lappend arg_list -skip_gate_cloning
}
repair_timing {*}$arg_list

set arg_list [list]
lappend arg_list -verbose
Expand All @@ -42,9 +48,6 @@ lappend arg_list -max_buffer_percent $::env(PL_RESIZER_HOLD_MAX_BUFFER_PCT)
if { $::env(PL_RESIZER_ALLOW_SETUP_VIOS) == 1 } {
lappend arg_list -allow_setup_violations
}
if { $::env(PL_RESIZER_GATE_CLONING) != 1 } {
lappend arg_list -skip_gate_cloning
}
repair_timing {*}$arg_list

# Legalize
Expand Down
15 changes: 9 additions & 6 deletions openlane/scripts/openroad/rsz_timing_postgrt.tcl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,15 @@ source $::env(SCRIPTS_DIR)/openroad/common/grt.tcl
estimate_parasitics -global_routing

# Resize
repair_timing -verbose -setup \
-setup_margin $::env(GRT_RESIZER_SETUP_SLACK_MARGIN) \
-max_buffer_percent $::env(GRT_RESIZER_SETUP_MAX_BUFFER_PCT)
set arg_list [list]
lappend arg_list -verbose
lappend arg_list -setup
lappend arg_list -setup_margin $::env(GRT_RESIZER_SETUP_SLACK_MARGIN)
lappend arg_list -max_buffer_percent $::env(GRT_RESIZER_SETUP_MAX_BUFFER_PCT)
if { $::env(GRT_RESIZER_GATE_CLONING) != 1 } {
lappend arg_list -skip_gate_cloning
}
repair_timing {*}$arg_list

set arg_list [list]
lappend arg_list -verbose
Expand All @@ -45,9 +51,6 @@ lappend arg_list -max_buffer_percent $::env(GRT_RESIZER_HOLD_MAX_BUFFER_PCT)
if { $::env(GRT_RESIZER_ALLOW_SETUP_VIOS) == 1 } {
lappend arg_list -allow_setup_violations
}
if { $::env(GRT_RESIZER_GATE_CLONING) != 1 } {
lappend arg_list -skip_gate_cloning
}
repair_timing {*}$arg_list

# Re-DPL and GRT
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tool.poetry]
name = "openlane"
version = "2.2.5"
version = "2.2.6"
description = "An infrastructure for implementing chip design flows"
authors = ["Efabless Corporation and Contributors <[email protected]>"]
readme = "Readme.md"
Expand Down
Loading