feat!: quit on hold violations on all corners

[kareefardi]

Steps

• Checker.HoldViolations

  • Change default value of HOLD_VIOLATION_CORNERS to ['*'] causing error
    on hold violations on all corners

---

Depends on efabless/openlane2-ci-designs#35
BREAKING CHANGE: Designs with hold violations on other corners than *tt* will now need updating

Fixes #523

[openlane-bot]

Metric comparisons are in beta. Please report bugs under the issues tab.

To create this report yourself, grab the metrics artifact from the CI run, extract them, and invoke python3 -m openlane.common.metrics compare-remote current --branch dev --table-verbosity ALL --table-out ./tables_all.md.

• Changes to critical metrics were detected in the following designs:
  • gf180mcuD/gf180mcu_fd_sc_mcu7t5v0/usb_cdc_core
  • sky130A/sky130_fd_sc_hd/MS_SPI_XIP_CACHE

Full tables ► https://gist.github.com/openlane-bot/39c1dff69b643845ec8ce2a0db2f7388

[donn]

While you're here, tt needs to be taken from the PDK instead of being set as part of the variable name. This already caused an issue or two with some of our internal PDKs.