Feature/785 documentation metadata #806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ure (eclipse-ditto#680). Corrections in basic-metadata.md and added changes to ditto-api-2.yml-Swagger Doc. Signed-off-by: julian <[email protected]>
JulianFeinauer
force-pushed
the
feature/785-documentation-metadata
branch
from
2f9cef5 to
5548ffa
Compare
|
The json-schema v2 needs to be changed too |
w4tsn
suggested changes
Sep 16, 2020
documentation/src/main/resources/pages/ditto/protocol-specification.md
Outdated
Show resolved
Hide resolved
…ex suggestion. Signed-off-by: julian <[email protected]>
Signed-off-by: julian <[email protected]>
Signed-off-by: julian <[email protected]>
thjaeckle
requested changes
Sep 17, 2020
documentation/src/main/resources/pages/ditto/protocol-specification.md
Outdated
Show resolved
Hide resolved
documentation/src/main/resources/pages/ditto/protocol-specification.md
Outdated
Show resolved
Hide resolved
I would like to proceed with this PR before releasing Ditto 1.3.0 - so I'm applying the suggestions I made. Still open is the addition of the page to the sitemap, will do a follow-up commit for that.
* fixed JsonSchema for Thing + Swagger * added link from basic-thing.md to metadata page * added metadata page to sidebar * fixed/adjusted some documentation + added more complete examples Signed-off-by: Thomas Jaeckle <[email protected]>
thjaeckle
approved these changes
Sep 21, 2020
|
@JulianFeinauer could you have a look on the changes I made? Are they ok for you? |
|
THanks for your support here, all changes are fine for me 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Documentation for the current implementation of the Metadata Feature and the necessary adjustment to the Swagger docs.